third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html - Issue 1908463002: Modernize fast/hidpi layout tests

Unified Diff: third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

Issue 1908463002: Modernize fast/hidpi layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add NeedsManualRebaseline Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-intrinsic-size-zero.html ('k') | third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-inputs.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

diff --git a/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html b/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

index 960c171a0e6d7197faa51f20efdcb84720b5d735..e40f61360835bb6a810e67245e21b8e0c35dbeb7 100644

--- a/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

+++ b/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

@@ -1,5 +1,4 @@

-<html>

-<head>

+<!DOCTYPE html>

window.targetScaleFactor = 1;

</script>

@@ -19,21 +18,16 @@

shouldBeTrue('document.getElementById("foo10").clientWidth==200');

}, false);

</script>

-</head>

-<body id="body">

- <div>This test passes if the image below is a 200px green square when the deviceScaleFactor is 1.</div>

- <div>It tests that the 1x resource is ignored since it contains invalid descriptors.</div>

- <div>The 2x resource has an intrinsic width of 200px, since it's a 400px wide image at 2x DPR.</div>

- <img id="foo" src="" srcset="resources/blue-100-px-square.png 43q 1x dfs 3dd, resources/green-400-px-square.png 2x">

- <img id="foo2" src="" srcset="resources/blue-100-px-square.png 300q, resources/green-400-px-square.png 2x">

- <img id="foo3" src="" srcset="resources/blue-100-px-square.png 100w 100w, resources/green-400-px-square.png 2x">

- <img id="foo4" src="" srcset="resources/blue-100-px-square.png 100h 100h, resources/green-400-px-square.png 2x">

- <img id="foo5" src="" srcset="resources/blue-100-px-square.png 100x 100h, resources/green-400-px-square.png 2x">

- <img id="foo6" src="" srcset="resources/blue-100-px-square.png 100x 100w, resources/green-400-px-square.png 2x">

- <img id="foo7" src="" srcset="resources/blue-100-px-square.png -100w, resources/green-400-px-square.png 2x">

- <img id="foo8" src="" srcset="resources/blue-100-px-square.png -100h, resources/green-400-px-square.png 2x">

- <img id="foo9" src="" srcset="resources/blue-100-px-square.png -1x, resources/green-400-px-square.png 2x">

- <img id="foo10" src="" srcset="resources/blue-100-px-square.png 100h, resources/green-400-px-square.png 2x">

-</body>

-</html>

+<div>This test passes if the image below is a 200px green square when the deviceScaleFactor is 1.</div>

+<div>It tests that the 1x resource is ignored since it contains invalid descriptors.</div>

+<div>The 2x resource has an intrinsic width of 200px, since it's a 400px wide image at 2x DPR.</div>

+<img id="foo" src="" srcset="resources/blue-100-px-square.png 43q 1x dfs 3dd, resources/green-400-px-square.png 2x">

+<img id="foo2" src="" srcset="resources/blue-100-px-square.png 300q, resources/green-400-px-square.png 2x">

+<img id="foo3" src="" srcset="resources/blue-100-px-square.png 100w 100w, resources/green-400-px-square.png 2x">

+<img id="foo4" src="" srcset="resources/blue-100-px-square.png 100h 100h, resources/green-400-px-square.png 2x">

+<img id="foo5" src="" srcset="resources/blue-100-px-square.png 100x 100h, resources/green-400-px-square.png 2x">

+<img id="foo6" src="" srcset="resources/blue-100-px-square.png 100x 100w, resources/green-400-px-square.png 2x">

+<img id="foo7" src="" srcset="resources/blue-100-px-square.png -100w, resources/green-400-px-square.png 2x">

+<img id="foo8" src="" srcset="resources/blue-100-px-square.png -100h, resources/green-400-px-square.png 2x">

+<img id="foo9" src="" srcset="resources/blue-100-px-square.png -1x, resources/green-400-px-square.png 2x">

+<img id="foo10" src="" srcset="resources/blue-100-px-square.png 100h, resources/green-400-px-square.png 2x">