third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-remove-dynamically-from-js.html - Issue 1908463002: Modernize fast/hidpi layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-remove-dynamically-from-js.html

Issue 1908463002: Modernize fast/hidpi layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add NeedsManualRebaseline Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-relative-svg-expected.html ('k') | third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-same-alternative-for-both-attributes.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-remove-dynamically-from-js.html

diff --git a/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-remove-dynamically-from-js.html b/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-remove-dynamically-from-js.html

index da48f31cf3531396213a803fec59940f779e02bd..0302dffebc34f389fbd3e89cd115a9c1c1bc6535 100644

--- a/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-remove-dynamically-from-js.html

+++ b/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-remove-dynamically-from-js.html

@@ -1,5 +1,4 @@

-<html>

-<head>

+<!DOCTYPE html>

window.targetScaleFactor = 1;

</script>

@@ -9,13 +8,11 @@

if (window.testRunner) {

testRunner.dumpAsText();

}

function updateSrc() {

var img = document.getElementById("foo");

// srcset must be set first, otherwise 'src' is loaded as well

img.src = "";

}

addEventListener("DOMContentLoaded", function() {

updateSrc();

}, false);

@@ -23,9 +20,5 @@

shouldBeTrue('document.getElementById("foo").clientWidth==200');

}, false);

</script>

-</head>

-<body id="body">

- <div>This test passes if this img tag below is a green square. It ensures that attributes can be removed dynamically from javascript</div>

- <img id="foo" src="resources/blue-100-px-square.png" srcset="resources/green-400-px-square.png 2x">

-</body>

-</html>

+<div>This test passes if this img tag below is a green square. It ensures that attributes can be removed dynamically from javascript</div>

+<img id="foo" src="resources/blue-100-px-square.png" srcset="resources/green-400-px-square.png 2x">