third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html - Issue 1908463002: Modernize fast/hidpi layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html

Issue 1908463002: Modernize fast/hidpi layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add NeedsManualRebaseline Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html ('k') | third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-change-resource-dpr.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <!DOCTYPE html>

2 <head>

3 <script>

4 </script>

5 <script src="resources/srcset-helper.js"></script>	2 <script src="resources/srcset-helper.js"></script>

6 <script src="../../resources/js-test.js"></script>	3 <script src="../../resources/js-test.js"></script>

7 <script>	4 <script>

8 function updateSrc() {	5 function updateSrc() {

9 var img = document.getElementById("foo");	6 var img = document.getElementById("foo");

10 // The below should not trigger the load of the blue image according to the spec.	7 // The below should not trigger the load of the blue image according to the spec.

11 img.src = "resources/blue-100-px-square.png"	8 img.src = "resources/blue-100-px-square.png"

12 img.srcset = "resources/blue-100-px-square.png 1x, resources/green-400-p x-square.png 2x";	9 img.srcset = "resources/blue-100-px-square.png 1x, resources/green-400-p x-square.png 2x";

13 }	10 }

14

15 addEventListener("DOMContentLoaded", function() {	11 addEventListener("DOMContentLoaded", function() {

16 if (window.testRunner && sessionStorage.pageReloaded) {	12 if (window.testRunner && sessionStorage.pageReloaded) {

17 // Have to make sure to only load the src after the reload.	13 // Have to make sure to only load the src after the reload.

18 // Otherwise, we'd request and cache the 1x URL while the	14 // Otherwise, we'd request and cache the 1x URL while the

19 // scale factor is 1, and after we reload we find the URL	15 // scale factor is 1, and after we reload we find the URL

20 // in the cache and reuse it, leading us to dump two requests.	16 // in the cache and reuse it, leading us to dump two requests.

21 updateSrc();	17 updateSrc();

22 } else if (!window.testRunner) {	18 } else if (!window.testRunner) {

23 // This else exists purely to allow running the test manually.	19 // This else exists purely to allow running the test manually.

24 updateSrc();	20 updateSrc();

25 }	21 }

26 }, false);	22 }, false);

27 addEventListener("load", function() {	23 addEventListener("load", function() {

28 shouldBeTrue('document.getElementById("foo").clientWidth==200');	24 shouldBeTrue('document.getElementById("foo").clientWidth==200');

29 }, false);	25 }, false);

30 </script>	26 </script>

31 </head>	27 <div>This test passes if this img tag below is a green square when the scale fac tor is 2.

32	28 It ensures that attributes can be changed dynamically from javascript, and t hat only the correct resource is loaded.</div>

33 <body id="body">	29 <img id="foo">

34 <div>This test passes if this img tag below is a green square when the scale factor is 2.

35 It ensures that attributes can be changed dynamically from javascript, and that only the correct resource is loaded.</div>

36 <img id="foo">

37 </body>

38 </html>

OLD	NEW