Issue 1907773002: Make QuicDispatcher's helper argument be a unique_ptr to make ownership

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1907773002: Make QuicDispatcher's helper argument be a unique_ptr to make ownership (Closed)

Created:
4 years, 8 months ago by Ryan Hamilton

Modified:
4 years, 8 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@119678304

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make QuicDispatcher's helper argument be a unique_ptr to make ownership clear. No behavior change. (also removes very out of date QuicDispatcher constructor comment) Merge internal change: 119753783 BUG=

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -24 lines)			Patch
M	net/quic/test_tools/mock_quic_dispatcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/test_tools/mock_quic_dispatcher.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.cc	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher_test.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	net/tools/quic/quic_server.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	net/tools/quic/quic_server_test.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	net/tools/quic/quic_simple_server.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/tools/quic/quic_simple_server_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/test_tools/quic_test_server.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Depends on Patchset:

Issue 1906703002 Patch 40001

Dependent Patchsets:

Issue 1905843003 Patch 20001

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages