net/tools/quic/quic_server.cc - Issue 1907773002: Make QuicDispatcher's helper argument be a unique_ptr to make ownership

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_server.cc

Issue 1907773002: Make QuicDispatcher's helper argument be a unique_ptr to make ownership (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119678304

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_server.cc

diff --git a/net/tools/quic/quic_server.cc b/net/tools/quic/quic_server.cc

index af7d7a828de6a46542410f742e57a647824779df..d0048d464c0f72f9f970605638a34173f5f1f986 100644

--- a/net/tools/quic/quic_server.cc

+++ b/net/tools/quic/quic_server.cc

@@ -144,9 +144,10 @@ QuicDefaultPacketWriter* QuicServer::CreateWriter(int fd) {

}

QuicDispatcher* QuicServer::CreateQuicDispatcher() {

- return new QuicDispatcher(config_, &crypto_config_, supported_versions_,

- new QuicEpollConnectionHelper(

- &epoll_server_, QuicAllocator::BUFFER_POOL));

+ return new QuicDispatcher(

+ config_, &crypto_config_, supported_versions_,

+ std::unique_ptr<QuicEpollConnectionHelper>(new QuicEpollConnectionHelper(

+ &epoll_server_, QuicAllocator::BUFFER_POOL)));

}

void QuicServer::WaitForEvents() {

« no previous file with comments | « net/tools/quic/quic_dispatcher_test.cc ('k') | net/tools/quic/quic_server_test.cc » ('j') | no next file with comments »