Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1950)

Unified Diff: net/tools/quic/quic_dispatcher.h

Issue 1907773002: Make QuicDispatcher's helper argument be a unique_ptr to make ownership (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119678304
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/mock_quic_dispatcher.cc ('k') | net/tools/quic/quic_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher.h
diff --git a/net/tools/quic/quic_dispatcher.h b/net/tools/quic/quic_dispatcher.h
index 5674a29dbed32e84b8a871a18036afe04dbfeaa8..44e1f5c3d116c8d1eceef70cbcd750e4afa5cc06 100644
--- a/net/tools/quic/quic_dispatcher.h
+++ b/net/tools/quic/quic_dispatcher.h
@@ -44,14 +44,10 @@ class QuicDispatcher : public QuicServerSessionVisitor,
QuicBlockedWriterInterfacePtrHash>
WriteBlockedList;
- // Due to the way delete_sessions_closure_ is registered, the Dispatcher must
- // live until server Shutdown. |supported_versions| specifies the std::list
- // of supported QUIC versions. Takes ownership of |packet_writer_factory|,
- // which is used to create per-connection writers.
QuicDispatcher(const QuicConfig& config,
const QuicCryptoServerConfig* crypto_config,
const QuicVersionVector& supported_versions,
- QuicConnectionHelperInterface* helper);
+ std::unique_ptr<QuicConnectionHelperInterface> helper);
~QuicDispatcher() override;
« no previous file with comments | « net/quic/test_tools/mock_quic_dispatcher.cc ('k') | net/tools/quic/quic_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698