Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: net/tools/quic/test_tools/quic_test_server.cc

Issue 1907773002: Make QuicDispatcher's helper argument be a unique_ptr to make ownership (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119678304
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_simple_server_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/test_tools/quic_test_server.cc
diff --git a/net/tools/quic/test_tools/quic_test_server.cc b/net/tools/quic/test_tools/quic_test_server.cc
index dc5fc45141d60470c9a63c2549bdff2dfff59e52..8ce3cfa65947cb79e26f836fc58e84db4a092912 100644
--- a/net/tools/quic/test_tools/quic_test_server.cc
+++ b/net/tools/quic/test_tools/quic_test_server.cc
@@ -76,8 +76,8 @@ class QuicTestDispatcher : public QuicDispatcher {
QuicTestDispatcher(const QuicConfig& config,
const QuicCryptoServerConfig* crypto_config,
const QuicVersionVector& versions,
- QuicConnectionHelperInterface* helper)
- : QuicDispatcher(config, crypto_config, versions, helper),
+ std::unique_ptr<QuicConnectionHelperInterface> helper)
+ : QuicDispatcher(config, crypto_config, versions, std::move(helper)),
session_factory_(nullptr),
stream_factory_(nullptr),
crypto_stream_factory_(nullptr) {}
@@ -150,8 +150,8 @@ QuicTestServer::QuicTestServer(ProofSource* proof_source,
QuicDispatcher* QuicTestServer::CreateQuicDispatcher() {
return new QuicTestDispatcher(
config(), &crypto_config(), supported_versions(),
- new QuicEpollConnectionHelper(epoll_server(),
- QuicAllocator::BUFFER_POOL));
+ std::unique_ptr<QuicEpollConnectionHelper>(new QuicEpollConnectionHelper(
+ epoll_server(), QuicAllocator::BUFFER_POOL)));
}
void QuicTestServer::SetSessionFactory(SessionFactory* factory) {
« no previous file with comments | « net/tools/quic/quic_simple_server_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698