Convert //components/sync_driver from scoped_ptr to std::unique_ptr

Convert //components/sync_driver from scoped_ptr to std::unique_ptr

BUG=554298
R=pavely@chromium.org

Committed: https://crrev.com/b21a1b10f9a753d3b66e448ca8fa74ac83d5c2cb
Cr-Commit-Position: refs/heads/master@{#388843}

[pavely, 2016-04-21 17:53:23]

lgtm

The reason for build failure is that profile_sync_components_factory_impl.h uses
scoped_ptr even though it doesn't include scoped_ptr.h.
Previousluy it worked because scoped_ptr.h was transitively included from
sync_api_component_factory.h.

To fix this could you include base/memory/scoped_ptr.h from
components/browser_sync/browser/profile_sync_components_factory_impl.h?

https://codereview.chromium.org/1907683003/diff/1/components/sync_driver/fake...
File components/sync_driver/fake_sync_client.h (right):

https://codereview.chromium.org/1907683003/diff/1/components/sync_driver/fake...
components/sync_driver/fake_sync_client.h:47: std::unique_ptr<FakeSyncService>
sync_service_;
Could you add #include <memory> in this file?

https://codereview.chromium.org/1907683003/diff/1/components/sync_driver/glue...
File components/sync_driver/glue/browser_thread_model_worker_unittest.cc
(right):

https://codereview.chromium.org/1907683003/diff/1/components/sync_driver/glue...
components/sync_driver/glue/browser_thread_model_worker_unittest.cc:7: #include
<memory>
Could you remove this include? I think scoped_ptr wasn't used in this file.

[dcheng, 2016-04-21 18:30:02]

Done. I fixed the compile errors slightly differently:
- If it's purely because of a base class interface, I just update the subclass
to use std::unique_ptr (logically, this kind of makes sense: if you're
implementing an interface, your interface should have included the types it
depends on)
- But if it's due to a random reference to scoped_ptr (e.g. a member), then I
add the header.

Let me know if this seems OK to you.

https://codereview.chromium.org/1907683003/diff/1/components/sync_driver/fake...
File components/sync_driver/fake_sync_client.h (right):

https://codereview.chromium.org/1907683003/diff/1/components/sync_driver/fake...
components/sync_driver/fake_sync_client.h:47: std::unique_ptr<FakeSyncService>
sync_service_;
On 2016/04/21 at 17:53:23, pavely wrote:
> Could you add #include <memory> in this file?

Done.

https://codereview.chromium.org/1907683003/diff/1/components/sync_driver/glue...
File components/sync_driver/glue/browser_thread_model_worker_unittest.cc
(right):

https://codereview.chromium.org/1907683003/diff/1/components/sync_driver/glue...
components/sync_driver/glue/browser_thread_model_worker_unittest.cc:7: #include
<memory>
On 2016/04/21 at 17:53:23, pavely wrote:
> Could you remove this include? I think scoped_ptr wasn't used in this file.

Done.

[pavely, 2016-04-21 18:34:19]

lgtm

[dcheng, 2016-04-21 18:34:32]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-04-21 18:34:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907683003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907683003/20001

[commit-bot: I haz the power, 2016-04-21 19:23:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:37:20]

Description was changed from

==========
Convert //components/sync_driver from scoped_ptr to std::unique_ptr

BUG=554298
R=pavely@chromium.org
==========

to

==========
Convert //components/sync_driver from scoped_ptr to std::unique_ptr

BUG=554298
R=pavely@chromium.org

Committed: https://crrev.com/b21a1b10f9a753d3b66e448ca8fa74ac83d5c2cb
Cr-Commit-Position: refs/heads/master@{#388843}
==========

[commit-bot: I haz the power, 2016-04-22 19:37:21]

Patchset 2 (id:??) landed as
https://crrev.com/b21a1b10f9a753d3b66e448ca8fa74ac83d5c2cb
Cr-Commit-Position: refs/heads/master@{#388843}