Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: components/sync_driver/sync_api_component_factory.h

Issue 1907683003: Convert //components/sync_driver from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Build fix, address feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SYNC_DRIVER_SYNC_API_COMPONENT_FACTORY_H_ 5 #ifndef COMPONENTS_SYNC_DRIVER_SYNC_API_COMPONENT_FACTORY_H_
6 #define COMPONENTS_SYNC_DRIVER_SYNC_API_COMPONENT_FACTORY_H_ 6 #define COMPONENTS_SYNC_DRIVER_SYNC_API_COMPONENT_FACTORY_H_
7 7
8 #include <memory>
8 #include <string> 9 #include <string>
9 10
10 #include "base/memory/scoped_ptr.h"
11 #include "base/memory/weak_ptr.h" 11 #include "base/memory/weak_ptr.h"
12 #include "components/sync_driver/data_type_controller.h" 12 #include "components/sync_driver/data_type_controller.h"
13 #include "sync/api/syncable_service.h" 13 #include "sync/api/syncable_service.h"
14 #include "sync/internal_api/public/attachments/attachment_service.h" 14 #include "sync/internal_api/public/attachments/attachment_service.h"
15 #include "sync/internal_api/public/base/model_type.h" 15 #include "sync/internal_api/public/base/model_type.h"
16 16
17 namespace base { 17 namespace base {
18 class FilePath; 18 class FilePath;
19 } // namespace base 19 } // namespace base
20 20
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 sync_driver::DataTypeManagerObserver* observer) = 0; 104 sync_driver::DataTypeManagerObserver* observer) = 0;
105 105
106 // Creating this in the factory helps us mock it out in testing. 106 // Creating this in the factory helps us mock it out in testing.
107 virtual browser_sync::SyncBackendHost* CreateSyncBackendHost( 107 virtual browser_sync::SyncBackendHost* CreateSyncBackendHost(
108 const std::string& name, 108 const std::string& name,
109 invalidation::InvalidationService* invalidator, 109 invalidation::InvalidationService* invalidator,
110 const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs, 110 const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs,
111 const base::FilePath& sync_folder) = 0; 111 const base::FilePath& sync_folder) = 0;
112 112
113 // Creating this in the factory helps us mock it out in testing. 113 // Creating this in the factory helps us mock it out in testing.
114 virtual scoped_ptr<sync_driver::LocalDeviceInfoProvider> 114 virtual std::unique_ptr<sync_driver::LocalDeviceInfoProvider>
115 CreateLocalDeviceInfoProvider() = 0; 115 CreateLocalDeviceInfoProvider() = 0;
116 116
117 // Legacy datatypes that need to be converted to the SyncableService API. 117 // Legacy datatypes that need to be converted to the SyncableService API.
118 virtual SyncComponents CreateBookmarkSyncComponents( 118 virtual SyncComponents CreateBookmarkSyncComponents(
119 sync_driver::SyncService* sync_service, 119 sync_driver::SyncService* sync_service,
120 sync_driver::DataTypeErrorHandler* error_handler) = 0; 120 sync_driver::DataTypeErrorHandler* error_handler) = 0;
121 121
122 // Creates attachment service. 122 // Creates attachment service.
123 // Note: Should only be called from the model type thread. 123 // Note: Should only be called from the model type thread.
124 // 124 //
125 // |store_birthday| is the store birthday. Must not be empty. 125 // |store_birthday| is the store birthday. Must not be empty.
126 // 126 //
127 // |model_type| is the model type this AttachmentService will be used with. 127 // |model_type| is the model type this AttachmentService will be used with.
128 // 128 //
129 // |delegate| is optional delegate for AttachmentService to notify about 129 // |delegate| is optional delegate for AttachmentService to notify about
130 // asynchronous events (AttachmentUploaded). Pass NULL if delegate is not 130 // asynchronous events (AttachmentUploaded). Pass NULL if delegate is not
131 // provided. AttachmentService doesn't take ownership of delegate, the pointer 131 // provided. AttachmentService doesn't take ownership of delegate, the pointer
132 // must be valid throughout AttachmentService lifetime. 132 // must be valid throughout AttachmentService lifetime.
133 virtual scoped_ptr<syncer::AttachmentService> CreateAttachmentService( 133 virtual std::unique_ptr<syncer::AttachmentService> CreateAttachmentService(
134 scoped_ptr<syncer::AttachmentStoreForSync> attachment_store, 134 std::unique_ptr<syncer::AttachmentStoreForSync> attachment_store,
135 const syncer::UserShare& user_share, 135 const syncer::UserShare& user_share,
136 const std::string& store_birthday, 136 const std::string& store_birthday,
137 syncer::ModelType model_type, 137 syncer::ModelType model_type,
138 syncer::AttachmentService::Delegate* delegate) = 0; 138 syncer::AttachmentService::Delegate* delegate) = 0;
139 }; 139 };
140 140
141 } // namespace sync_driver 141 } // namespace sync_driver
142 142
143 #endif // COMPONENTS_SYNC_DRIVER_SYNC_API_COMPONENT_FACTORY_H_ 143 #endif // COMPONENTS_SYNC_DRIVER_SYNC_API_COMPONENT_FACTORY_H_
OLDNEW
« no previous file with comments | « components/sync_driver/startup_controller_unittest.cc ('k') | components/sync_driver/sync_api_component_factory_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698