components/sync_driver/local_device_info_provider_impl.h - Issue 1907683003: Convert //components/sync_driver from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/local_device_info_provider_impl.h

Issue 1907683003: Convert //components/sync_driver from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Build fix, address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/local_device_info_provider.h ('k') | components/sync_driver/local_device_info_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/local_device_info_provider_impl.h

diff --git a/components/sync_driver/local_device_info_provider_impl.h b/components/sync_driver/local_device_info_provider_impl.h

index 306f81fa55c4bd3febcfc0de7892dbe109dea147..29dc715228add1d0c8db55c0d91854365ebb523c 100644

--- a/components/sync_driver/local_device_info_provider_impl.h

+++ b/components/sync_driver/local_device_info_provider_impl.h

@@ -29,7 +29,7 @@ class LocalDeviceInfoProviderImpl

const std::string& cache_guid,

const std::string& signin_scoped_device_id,

const scoped_refptr<base::TaskRunner>& blocking_task_runner) override;

- scoped_ptr<Subscription> RegisterOnInitializedCallback(

+ std::unique_ptr<Subscription> RegisterOnInitializedCallback(

const base::Closure& callback) override;

private:

@@ -48,7 +48,7 @@ class LocalDeviceInfoProviderImpl

const bool is_tablet_;

std::string cache_guid_;

- scoped_ptr<sync_driver::DeviceInfo> local_device_info_;

+ std::unique_ptr<sync_driver::DeviceInfo> local_device_info_;

base::CallbackList<void(void)> callback_list_;

base::WeakPtrFactory<LocalDeviceInfoProviderImpl> weak_factory_;

« no previous file with comments | « components/sync_driver/local_device_info_provider.h ('k') | components/sync_driver/local_device_info_provider_impl.cc » ('j') | no next file with comments »