components/sync_driver/non_ui_data_type_controller_unittest.cc - Issue 1907683003: Convert //components/sync_driver from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/non_ui_data_type_controller_unittest.cc

Issue 1907683003: Convert //components/sync_driver from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Build fix, address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/non_ui_data_type_controller.cc ('k') | components/sync_driver/non_ui_model_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/non_ui_data_type_controller_unittest.cc

diff --git a/components/sync_driver/non_ui_data_type_controller_unittest.cc b/components/sync_driver/non_ui_data_type_controller_unittest.cc

index db773ba1b1ed12362e2bf0ac901fa78b92437c38..25322d65ee9cc1aa81c59e4f16590925c3b180c3 100644

--- a/components/sync_driver/non_ui_data_type_controller_unittest.cc

+++ b/components/sync_driver/non_ui_data_type_controller_unittest.cc

@@ -4,6 +4,7 @@

#include "components/sync_driver/non_ui_data_type_controller.h"

+#include <memory>

#include <vector>

#include "base/bind.h"

@@ -12,7 +13,6 @@

#include "base/compiler_specific.h"

#include "base/location.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/single_thread_task_runner.h"

#include "base/synchronization/waitable_event.h"

#include "base/test/test_timeouts.h"

@@ -275,7 +275,7 @@ class SyncNonUIDataTypeControllerTest : public testing::Test,

scoped_refptr<NonUIDataTypeControllerFake> non_ui_dtc_;

scoped_refptr<NonUIDataTypeControllerMock> dtc_mock_;

scoped_refptr<SharedChangeProcessorMock> change_processor_;

- scoped_ptr<syncer::SyncChangeProcessor> saved_change_processor_;

+ std::unique_ptr<syncer::SyncChangeProcessor> saved_change_processor_;

};

TEST_F(SyncNonUIDataTypeControllerTest, StartOk) {