third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html - Issue 1907443007: Use promises in notifications tests and enable controlling the page.

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html

Issue 1907443007: Use promises in notifications tests and enable controlling the page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Address peter's comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclick-openwindow-crash.html ('k') | third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-click.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Notifications: Check that showNotifications rejects if actions is set incorrectly.</title>	4 <title>Notifications: Check that showNotifications rejects if actions is set incorrectly.</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="../serviceworker/resources/test-helpers.js"></script>	7 <script src="../serviceworker/resources/test-helpers.js"></script>

8 <script src="resources/test-helpers.js"></script>	8 <script src="resources/test-helpers.js"></script>

9 </head>	9 </head>

10 <body>	10 <body>

11 <script>	11 <script>

12 // Tests that serviceWorkerRegistration.showNotification throws a	12 // Tests that serviceWorkerRegistration.showNotification throws a

13 // TypeError if NotificationOptions.actions is set incorrectly.	13 // TypeError if NotificationOptions.actions is set incorrectly.

14 var script = 'resources/instrumentation-service-worker.js';	14 var script = 'instrumentation-service-worker.js';

15	15

16 testRunner.setPermission('notifications', 'granted', location.origin, loca tion.origin);	16 testRunner.setPermission('notifications', 'granted', location.origin, loca tion.origin);

17	17

18 async_test(function(test) {	18 async_test(function(test) {

19 var scope = 'resources/scope/' + location.pathname + "/noaction";	19 var scope = 'resources/scope/' + location.pathname + "/noaction";

20	20

21 getActiveServiceWorkerWithMessagePort(test, script, scope).then(functi on(workerInfo) {	21 getActiveServiceWorkerWithMessagePort(test, script, scope).then(functi on(workerInfo) {

22 assert_inherits(workerInfo.registration, 'showNotification', 'show Notification() must be exposed.');	22 assert_inherits(workerInfo.registration, 'showNotification', 'show Notification() must be exposed.');

23	23

24 workerInfo.registration.showNotification('Title', {	24 workerInfo.registration.showNotification('Title', {

(...skipping 19 matching lines...) Expand all Loading...
44 assert_equals(error.name, 'TypeError');	44 assert_equals(error.name, 'TypeError');

45 assert_equals(error.message, "Failed to execute 'showNotificat ion' on 'ServiceWorkerRegistration': required member title is undefined.");	45 assert_equals(error.message, "Failed to execute 'showNotificat ion' on 'ServiceWorkerRegistration': required member title is undefined.");

46 test.done();	46 test.done();

47 });	47 });

48 }).catch(unreached_rejection(test));	48 }).catch(unreached_rejection(test));

49	49

50 }, 'showNotification() must reject if a NotificationAction has no title.') ;	50 }, 'showNotification() must reject if a NotificationAction has no title.') ;

51 </script>	51 </script>

52 </body>	52 </body>

53 </html>	53 </html>

OLD	NEW