Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1907363004: (Merge to M-51) Revise the shelf alignment locking mechanism. (Closed)

Created:
4 years, 8 months ago by msw
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

(Merge to M-51) Revise the shelf alignment locking mechanism. Add a new SHELF_ALIGNMENT_LOCKED, not stored in user prefs. (similar to existing SHELF_AUTO_HIDE_ALWAYS_HIDDEN behavior) Add a new Shelf member, ShelfLockingManager. This locks (bottom) alignment on screen lock and user addition. Fixes a regression from https://codereview.chromium.org/1851883002 TODO: Move more state tracking (for visibility) out of LayoutManager. BUG=603243 TEST=Locking Chrome OS moves shelf to bottom. R=sky@chromium.org Review URL: https://codereview.chromium.org/1877543002 Cr-Commit-Position: refs/heads/master@{#388021} (cherry picked from commit 67a576240caed1c3783e6465d6c07998a2fc0b07) Committed: https://chromium.googlesource.com/chromium/src/+/2b215eb84a43373060023baca3e3f375e73376e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -432 lines) Patch
M ash/ash.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/shelf/shelf.h View 4 chunks +8 lines, -11 lines 0 comments Download
M ash/shelf/shelf.cc View 2 chunks +5 lines, -13 lines 0 comments Download
M ash/shelf/shelf_bezel_event_filter.cc View 1 chunk +5 lines, -18 lines 0 comments Download
M ash/shelf/shelf_button.cc View 2 chunks +9 lines, -12 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 2 chunks +1 line, -5 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 6 chunks +5 lines, -25 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 4 chunks +11 lines, -6 lines 0 comments Download
A ash/shelf/shelf_locking_manager.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ash/shelf/shelf_locking_manager.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M ash/shelf/shelf_types.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/shelf/shelf_util.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ash/shelf/shelf_util.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 6 chunks +13 lines, -12 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 16 chunks +58 lines, -99 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 4 chunks +22 lines, -0 lines 0 comments Download
M ash/shell.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/cast/tray_cast.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/date/tray_date.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/overview/overview_button_tray.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 5 chunks +8 lines, -13 lines 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 5 chunks +8 lines, -12 lines 0 comments Download
M ash/system/tray/tray_image_item.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M ash/system/tray/tray_item_view.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/system/tray/tray_utils.cc View 4 chunks +7 lines, -12 lines 0 comments Download
M ash/system/user/tray_user.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 2 chunks +7 lines, -17 lines 0 comments Download
M ash/test/shelf_test_api.h View 1 chunk +8 lines, -11 lines 0 comments Download
D ash/test/shelf_test_api.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M ash/wm/panels/attached_panel_window_targeter.cc View 1 chunk +4 lines, -14 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 6 chunks +22 lines, -40 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 3 chunks +14 lines, -26 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/window_animations.cc View 1 chunk +6 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc View 2 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
msw
4 years, 8 months ago (2016-04-22 19:29:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b215eb84a43373060023baca3e3f375e73376e8.

Powered by Google App Engine
This is Rietveld 408576698