Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

Issue 1907363004: (Merge to M-51) Revise the shelf alignment locking mechanism. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/first_run/first_run_ui.h" 5 #include "chrome/browser/ui/webui/chromeos/first_run/first_run_ui.h"
6 6
7 #include "ash/shell.h" 7 #include "ash/shelf/shelf.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
11 #include "chrome/browser/ui/webui/chromeos/first_run/first_run_handler.h" 11 #include "chrome/browser/ui/webui/chromeos/first_run/first_run_handler.h"
12 #include "chrome/common/url_constants.h" 12 #include "chrome/common/url_constants.h"
13 #include "chrome/grit/chromium_strings.h" 13 #include "chrome/grit/chromium_strings.h"
14 #include "chrome/grit/generated_resources.h" 14 #include "chrome/grit/generated_resources.h"
15 #include "chromeos/chromeos_switches.h" 15 #include "chromeos/chromeos_switches.h"
16 #include "content/public/browser/web_ui.h" 16 #include "content/public/browser/web_ui.h"
17 #include "content/public/browser/web_ui_data_source.h" 17 #include "content/public/browser/web_ui_data_source.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 l10n_util::GetStringUTF16(IDS_FIRST_RUN_HELP_STEP_KEEP_EXPLORING_BUTTON)); 54 l10n_util::GetStringUTF16(IDS_FIRST_RUN_HELP_STEP_KEEP_EXPLORING_BUTTON));
55 localized_strings->SetString( 55 localized_strings->SetString(
56 "helpFinishButton", 56 "helpFinishButton",
57 l10n_util::GetStringUTF16(IDS_FIRST_RUN_HELP_STEP_FINISH_BUTTON)); 57 l10n_util::GetStringUTF16(IDS_FIRST_RUN_HELP_STEP_FINISH_BUTTON));
58 localized_strings->SetString( 58 localized_strings->SetString(
59 "nextButton", l10n_util::GetStringUTF16(IDS_FIRST_RUN_NEXT_BUTTON)); 59 "nextButton", l10n_util::GetStringUTF16(IDS_FIRST_RUN_NEXT_BUTTON));
60 localized_strings->SetBoolean( 60 localized_strings->SetBoolean(
61 "transitionsEnabled", 61 "transitionsEnabled",
62 base::CommandLine::ForCurrentProcess()->HasSwitch( 62 base::CommandLine::ForCurrentProcess()->HasSwitch(
63 chromeos::switches::kEnableFirstRunUITransitions)); 63 chromeos::switches::kEnableFirstRunUITransitions));
64 std::string shelf_alignment; 64 const std::string& shelf_alignment =
65 ash::Shell* shell = ash::Shell::GetInstance(); 65 ash::Shelf::ForPrimaryDisplay()->SelectValueForShelfAlignment(
66 switch (shell->GetShelfAlignment(shell->GetPrimaryRootWindow())) { 66 kShelfAlignmentBottom, kShelfAlignmentLeft, kShelfAlignmentRight);
67 case ash::SHELF_ALIGNMENT_BOTTOM:
68 shelf_alignment = kShelfAlignmentBottom;
69 break;
70 case ash::SHELF_ALIGNMENT_LEFT:
71 shelf_alignment = kShelfAlignmentLeft;
72 break;
73 case ash::SHELF_ALIGNMENT_RIGHT:
74 shelf_alignment = kShelfAlignmentRight;
75 break;
76 default:
77 NOTREACHED() << "Unsupported shelf alignment";
78 }
79 localized_strings->SetString("shelfAlignment", shelf_alignment); 67 localized_strings->SetString("shelfAlignment", shelf_alignment);
80 } 68 }
81 69
82 content::WebUIDataSource* CreateDataSource() { 70 content::WebUIDataSource* CreateDataSource() {
83 content::WebUIDataSource* source = 71 content::WebUIDataSource* source =
84 content::WebUIDataSource::Create(chrome::kChromeUIFirstRunHost); 72 content::WebUIDataSource::Create(chrome::kChromeUIFirstRunHost);
85 source->SetJsonPath("strings.js"); 73 source->SetJsonPath("strings.js");
86 source->SetDefaultResource(IDR_FIRST_RUN_HTML); 74 source->SetDefaultResource(IDR_FIRST_RUN_HTML);
87 source->AddResourcePath(kFirstRunJSPath, IDR_FIRST_RUN_JS); 75 source->AddResourcePath(kFirstRunJSPath, IDR_FIRST_RUN_JS);
88 base::DictionaryValue localized_strings; 76 base::DictionaryValue localized_strings;
(...skipping 12 matching lines...) Expand all
101 : WebUIController(web_ui), 89 : WebUIController(web_ui),
102 actor_(NULL) { 90 actor_(NULL) {
103 FirstRunHandler* handler = new FirstRunHandler(); 91 FirstRunHandler* handler = new FirstRunHandler();
104 actor_ = handler; 92 actor_ = handler;
105 web_ui->AddMessageHandler(handler); 93 web_ui->AddMessageHandler(handler);
106 content::WebUIDataSource::Add(Profile::FromWebUI(web_ui), CreateDataSource()); 94 content::WebUIDataSource::Add(Profile::FromWebUI(web_ui), CreateDataSource());
107 } 95 }
108 96
109 } // namespace chromeos 97 } // namespace chromeos
110 98
OLDNEW
« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698