Revise the shelf alignment locking mechanism.

Revise the shelf alignment locking mechanism.

Add a new SHELF_ALIGNMENT_LOCKED, not stored in user prefs.
(similar to existing SHELF_AUTO_HIDE_ALWAYS_HIDDEN behavior)

Add a new Shelf member, ShelfLockingManager.
This locks (bottom) alignment on screen lock and user addition.

Fixes a regression from https://codereview.chromium.org/1851883002

TODO: Move more state tracking (for visibility) out of LayoutManager.

BUG=603243
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org

Committed: https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07
Cr-Commit-Position: refs/heads/master@{#388021}

[msw, 2016-04-15 18:12:33]

Patchset #1 (id:1) has been deleted

[msw, 2016-04-15 21:54:59]

Description was changed from

==========
Revise the shelf alignment locking mechanism.

BUG=
==========

to

==========
Revise the shelf alignment locking mechanism.

Add a new shelf alignment value SHELF_ALIGNMENT_LOCKED.
Lock/unlock the shelf with screen lock and user addition.
Do not store SHELF_ALIGNMENT_LOCKED to user prefs.

Fixes a regression from https://codereview.chromium.org/1851883002

BUG=603243
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org
==========

[msw, 2016-04-15 21:54:59]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-04-15 23:07:10]

Patchset #4 (id:80001) has been deleted

[msw, 2016-04-15 23:15:23]

Description was changed from

==========
Revise the shelf alignment locking mechanism.

Add a new shelf alignment value SHELF_ALIGNMENT_LOCKED.
Lock/unlock the shelf with screen lock and user addition.
Do not store SHELF_ALIGNMENT_LOCKED to user prefs.

Fixes a regression from https://codereview.chromium.org/1851883002

BUG=603243
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org
==========

to

==========
Revise the shelf alignment locking mechanism.

Add a new shelf alignment value SHELF_ALIGNMENT_LOCKED.
Shelf locks alignment on screen lock and user addition.
(ShelfLayoutManager still tracks state for visibility)
Do not store SHELF_ALIGNMENT_LOCKED to user prefs.

Fixes a regression from https://codereview.chromium.org/1851883002

TODO: Move more state tracking to Shelf, not LayoutManager.

BUG=603243
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org
==========

[msw, 2016-04-15 23:16:23]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 23:16:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877543002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877543002/100001

[msw, 2016-04-15 23:56:49]

Patchset #5 (id:120001) has been deleted

[msw, 2016-04-16 00:25:12]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-16 00:26:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877543002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877543002/140001

[msw, 2016-04-16 00:30:45]

Hey Scott, please take a look; thanks!

SHELF_ALIGNMENT_LOCKED parallels SHELF_AUTO_HIDE_ALWAYS_HIDDEN (set temporarily,
not a behavior selected by the user, and not meant to be saved as a user
preference). We could alternatively avoid adding SHELF_ALIGNMENT_LOCKED and make
ShelfDelegate::OnShelfAlignmentChanged take a bool flag to denote the
not-to-be-saved-as-a-pref, temporarily-set-for-locking intent.

[commit-bot: I haz the power, 2016-04-16 01:22:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-16 01:22:11]

Dry run: This issue passed the CQ dry run.

[msw, 2016-04-16 15:42:47]

Description was changed from

==========
Revise the shelf alignment locking mechanism.

Add a new shelf alignment value SHELF_ALIGNMENT_LOCKED.
Shelf locks alignment on screen lock and user addition.
(ShelfLayoutManager still tracks state for visibility)
Do not store SHELF_ALIGNMENT_LOCKED to user prefs.

Fixes a regression from https://codereview.chromium.org/1851883002

TODO: Move more state tracking to Shelf, not LayoutManager.

BUG=603243
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org
==========

to

==========
Revise the shelf alignment locking mechanism.

Add a new SHELF_ALIGNMENT_LOCKED, not stored in user prefs.
(similar to existing SHELF_AUTO_HIDE_ALWAYS_HIDDEN behavior)

Add a new Shelf member, ShelfLockingManager.
This locks (bottom) alignment on screen lock and user addition.

Fixes a regression from https://codereview.chromium.org/1851883002

TODO: Move more state tracking (for visibility) out of LayoutManager.

BUG=603243
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org
==========

[sky, 2016-04-18 15:17:00]

LGTM

https://codereview.chromium.org/1877543002/diff/160001/ash/shelf/shelf_types.h
File ash/shelf/shelf_types.h (right):

https://codereview.chromium.org/1877543002/diff/160001/ash/shelf/shelf_types....
ash/shelf/shelf_types.h:14: SHELF_ALIGNMENT_LOCKED,
If LOCKED always == BOTTOM I think this would be better named
SHELF_ALIGNMENT_BOTTOM_LOCKED, with a comment.

[msw, 2016-04-18 18:13:00]

https://codereview.chromium.org/1877543002/diff/160001/ash/shelf/shelf_types.h
File ash/shelf/shelf_types.h (right):

https://codereview.chromium.org/1877543002/diff/160001/ash/shelf/shelf_types....
ash/shelf/shelf_types.h:14: SHELF_ALIGNMENT_LOCKED,
On 2016/04/18 15:17:00, sky wrote:
> If LOCKED always == BOTTOM I think this would be better named
> SHELF_ALIGNMENT_BOTTOM_LOCKED, with a comment.

Done.

[msw, 2016-04-18 18:13:05]

The CQ bit was checked by msw@chromium.org

[msw, 2016-04-18 18:13:06]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1877543002/#ps180001
(title: "Rename SHELF_ALIGNMENT_BOTTOM_LOCKED, add comment.")

[commit-bot: I haz the power, 2016-04-18 18:13:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877543002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877543002/180001

[commit-bot: I haz the power, 2016-04-18 18:28:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 18:28:34]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[msw, 2016-04-18 18:34:50]

Patchset #7 (id:180001) has been deleted

[msw, 2016-04-18 18:34:55]

The CQ bit was checked by msw@chromium.org

[msw, 2016-04-18 18:34:56]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1877543002/#ps200001
(title: "Rename SHELF_ALIGNMENT_BOTTOM_LOCKED, add comment.")

[commit-bot: I haz the power, 2016-04-18 18:35:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877543002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877543002/200001

[commit-bot: I haz the power, 2016-04-18 18:51:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 18:51:23]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-04-18 20:08:16]

The CQ bit was checked by msw@chromium.org

[msw, 2016-04-18 20:08:17]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1877543002/#ps220001
(title: "Update and cleanup tests.")

[commit-bot: I haz the power, 2016-04-18 20:08:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877543002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877543002/220001

[commit-bot: I haz the power, 2016-04-18 21:06:22]

Description was changed from

==========
Revise the shelf alignment locking mechanism.

Add a new SHELF_ALIGNMENT_LOCKED, not stored in user prefs.
(similar to existing SHELF_AUTO_HIDE_ALWAYS_HIDDEN behavior)

Add a new Shelf member, ShelfLockingManager.
This locks (bottom) alignment on screen lock and user addition.

Fixes a regression from https://codereview.chromium.org/1851883002

TODO: Move more state tracking (for visibility) out of LayoutManager.

BUG=603243
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org
==========

to

==========
Revise the shelf alignment locking mechanism.

Add a new SHELF_ALIGNMENT_LOCKED, not stored in user prefs.
(similar to existing SHELF_AUTO_HIDE_ALWAYS_HIDDEN behavior)

Add a new Shelf member, ShelfLockingManager.
This locks (bottom) alignment on screen lock and user addition.

Fixes a regression from https://codereview.chromium.org/1851883002

TODO: Move more state tracking (for visibility) out of LayoutManager.

BUG=603243
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-04-18 21:06:23]

Committed patchset #8 (id:220001)

[commit-bot: I haz the power, 2016-04-18 21:08:59]

Description was changed from

==========
Revise the shelf alignment locking mechanism.

Add a new SHELF_ALIGNMENT_LOCKED, not stored in user prefs.
(similar to existing SHELF_AUTO_HIDE_ALWAYS_HIDDEN behavior)

Add a new Shelf member, ShelfLockingManager.
This locks (bottom) alignment on screen lock and user addition.

Fixes a regression from https://codereview.chromium.org/1851883002

TODO: Move more state tracking (for visibility) out of LayoutManager.

BUG=603243
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org
==========

to

==========
Revise the shelf alignment locking mechanism.

Add a new SHELF_ALIGNMENT_LOCKED, not stored in user prefs.
(similar to existing SHELF_AUTO_HIDE_ALWAYS_HIDDEN behavior)

Add a new Shelf member, ShelfLockingManager.
This locks (bottom) alignment on screen lock and user addition.

Fixes a regression from https://codereview.chromium.org/1851883002

TODO: Move more state tracking (for visibility) out of LayoutManager.

BUG=603243
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org

Committed: https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07
Cr-Commit-Position: refs/heads/master@{#388021}
==========

[commit-bot: I haz the power, 2016-04-18 21:09:01]

Patchset 8 (id:??) landed as
https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07
Cr-Commit-Position: refs/heads/master@{#388021}