Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1906363002: CSSGradientValue::getStopColors(): unnecessary use of HeapVector<>. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-css, devtools-reviews_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSSGradientValue::getStopColors(): unnecessary use of HeapVector<>. No need to involve HeapVector<> over Color. R= BUG= Committed: https://crrev.com/d9134831348d87ab14f87dd1905b0e9c2ced6748 Cr-Commit-Position: refs/heads/master@{#389368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/css/CSSGradientValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSGradientValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906363002/1
4 years, 8 months ago (2016-04-22 09:47:43 UTC) #2
sof
please take a look.
4 years, 8 months ago (2016-04-22 09:47:54 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 11:27:34 UTC) #6
haraken
LGTM
4 years, 8 months ago (2016-04-22 18:05:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906363002/1
4 years, 8 months ago (2016-04-23 06:13:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-23 06:21:52 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 06:23:18 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d9134831348d87ab14f87dd1905b0e9c2ced6748
Cr-Commit-Position: refs/heads/master@{#389368}

Powered by Google App Engine
This is Rietveld 408576698