Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSGradientValue.h

Issue 1906363002: CSSGradientValue::getStopColors(): unnecessary use of HeapVector<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSGradientValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 CSSGradientType gradientType() const { return m_gradientType; } 104 CSSGradientType gradientType() const { return m_gradientType; }
105 105
106 bool isFixedSize() const { return false; } 106 bool isFixedSize() const { return false; }
107 IntSize fixedSize(const LayoutObject&) const { return IntSize(); } 107 IntSize fixedSize(const LayoutObject&) const { return IntSize(); }
108 108
109 bool isPending() const { return false; } 109 bool isPending() const { return false; }
110 bool knownToBeOpaque(const LayoutObject&) const; 110 bool knownToBeOpaque(const LayoutObject&) const;
111 111
112 void loadSubimages(Document*) { } 112 void loadSubimages(Document*) { }
113 113
114 void getStopColors(HeapVector<Color>& stopColors, const LayoutObject&) const ; 114 void getStopColors(Vector<Color>& stopColors, const LayoutObject&) const;
115 115
116 DECLARE_TRACE_AFTER_DISPATCH(); 116 DECLARE_TRACE_AFTER_DISPATCH();
117 117
118 protected: 118 protected:
119 CSSGradientValue(ClassType classType, CSSGradientRepeat repeat, CSSGradientT ype gradientType) 119 CSSGradientValue(ClassType classType, CSSGradientRepeat repeat, CSSGradientT ype gradientType)
120 : CSSImageGeneratorValue(classType) 120 : CSSImageGeneratorValue(classType)
121 , m_stopsSorted(false) 121 , m_stopsSorted(false)
122 , m_gradientType(gradientType) 122 , m_gradientType(gradientType)
123 , m_repeating(repeat == Repeating) 123 , m_repeating(repeat == Repeating)
124 { 124 {
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 222
223 Member<CSSPrimitiveValue> m_endHorizontalSize; 223 Member<CSSPrimitiveValue> m_endHorizontalSize;
224 Member<CSSPrimitiveValue> m_endVerticalSize; 224 Member<CSSPrimitiveValue> m_endVerticalSize;
225 }; 225 };
226 226
227 DEFINE_CSS_VALUE_TYPE_CASTS(CSSRadialGradientValue, isRadialGradientValue()); 227 DEFINE_CSS_VALUE_TYPE_CASTS(CSSRadialGradientValue, isRadialGradientValue());
228 228
229 } // namespace blink 229 } // namespace blink
230 230
231 #endif // CSSGradientValue_h 231 #endif // CSSGradientValue_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSGradientValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698