third_party/WebKit/Source/core/css/CSSGradientValue.cpp - Issue 1906363002: CSSGradientValue::getStopColors(): unnecessary use of HeapVector<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSGradientValue.cpp

Issue 1906363002: CSSGradientValue::getStopColors(): unnecessary use of HeapVector<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSGradientValue.h ('k') | third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSGradientValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSGradientValue.cpp b/third_party/WebKit/Source/core/css/CSSGradientValue.cpp

index 32f7a3546eb6ebf8412f6d717dd472c7fe6b8e2c..32740d37cd1b17d145ebcaad6e72ea5ead595891 100644

--- a/third_party/WebKit/Source/core/css/CSSGradientValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSGradientValue.cpp

@@ -573,7 +573,7 @@ bool CSSGradientValue::knownToBeOpaque(const LayoutObject& object) const

return true;

}

-void CSSGradientValue::getStopColors(HeapVector<Color>& stopColors, const LayoutObject& object) const

+void CSSGradientValue::getStopColors(Vector<Color>& stopColors, const LayoutObject& object) const

{

for (auto& stop : m_stops) {

if (!stop.isHint())