Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSGradientValue.cpp

Issue 1906363002: CSSGradientValue::getStopColors(): unnecessary use of HeapVector<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2015 Google Inc. All rights reserved. 3 * Copyright (C) 2015 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 555 matching lines...) Expand 10 before | Expand all | Expand 10 after
566 566
567 bool CSSGradientValue::knownToBeOpaque(const LayoutObject& object) const 567 bool CSSGradientValue::knownToBeOpaque(const LayoutObject& object) const
568 { 568 {
569 for (auto& stop : m_stops) { 569 for (auto& stop : m_stops) {
570 if (!stop.isHint() && resolveStopColor(*stop.m_color, object).hasAlpha() ) 570 if (!stop.isHint() && resolveStopColor(*stop.m_color, object).hasAlpha() )
571 return false; 571 return false;
572 } 572 }
573 return true; 573 return true;
574 } 574 }
575 575
576 void CSSGradientValue::getStopColors(HeapVector<Color>& stopColors, const Layout Object& object) const 576 void CSSGradientValue::getStopColors(Vector<Color>& stopColors, const LayoutObje ct& object) const
577 { 577 {
578 for (auto& stop : m_stops) { 578 for (auto& stop : m_stops) {
579 if (!stop.isHint()) 579 if (!stop.isHint())
580 stopColors.append(resolveStopColor(*stop.m_color, object)); 580 stopColors.append(resolveStopColor(*stop.m_color, object));
581 } 581 }
582 582
583 } 583 }
584 584
585 DEFINE_TRACE_AFTER_DISPATCH(CSSGradientValue) 585 DEFINE_TRACE_AFTER_DISPATCH(CSSGradientValue)
586 { 586 {
(...skipping 629 matching lines...) Expand 10 before | Expand all | Expand 10 after
1216 visitor->trace(m_firstRadius); 1216 visitor->trace(m_firstRadius);
1217 visitor->trace(m_secondRadius); 1217 visitor->trace(m_secondRadius);
1218 visitor->trace(m_shape); 1218 visitor->trace(m_shape);
1219 visitor->trace(m_sizingBehavior); 1219 visitor->trace(m_sizingBehavior);
1220 visitor->trace(m_endHorizontalSize); 1220 visitor->trace(m_endHorizontalSize);
1221 visitor->trace(m_endVerticalSize); 1221 visitor->trace(m_endVerticalSize);
1222 CSSGradientValue::traceAfterDispatch(visitor); 1222 CSSGradientValue::traceAfterDispatch(visitor);
1223 } 1223 }
1224 1224
1225 } // namespace blink 1225 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSGradientValue.h ('k') | third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698