Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1906173002: Convert //components/metrics from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
asvitkine+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //components/metrics from scoped_ptr to std::unique_ptr BUG=554298 R=mpearson@chromium.org Committed: https://crrev.com/d99c42a1a3c4566d5cdbac0bbbed5c266d09cfeb Cr-Commit-Position: refs/heads/master@{#388913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -214 lines) Patch
M components/metrics/cloned_install_detector_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics/daily_event.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/metrics/daily_event.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/daily_event_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/metrics/data_use_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/data_use_tracker.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/metrics/file_metrics_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics/file_metrics_provider.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M components/metrics/file_metrics_provider_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/metrics/histogram_encoder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/metrics/leak_detector/call_stack_manager_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M components/metrics/leak_detector/call_stack_table_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics/leak_detector/leak_detector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics/leak_detector/leak_detector_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics/metrics_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/metrics_log_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/metrics/metrics_log_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/metrics_log_manager_unittest.cc View 11 chunks +16 lines, -15 lines 0 comments Download
M components/metrics/metrics_service.h View 7 chunks +9 lines, -8 lines 0 comments Download
M components/metrics/metrics_service.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M components/metrics/metrics_service_client.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/metrics/metrics_service_unittest.cc View 10 chunks +16 lines, -15 lines 0 comments Download
M components/metrics/metrics_state_manager.h View 5 chunks +8 lines, -6 lines 0 comments Download
M components/metrics/metrics_state_manager.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M components/metrics/metrics_state_manager_unittest.cc View 17 chunks +22 lines, -22 lines 0 comments Download
M components/metrics/net/net_metrics_log_uploader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics/net/net_metrics_log_uploader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/net/network_metrics_provider.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/metrics/net/network_metrics_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/metrics/profiler/content/content_tracking_synchronizer_delegate.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/metrics/profiler/content/content_tracking_synchronizer_delegate.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/metrics/profiler/ios/ios_tracking_synchronizer_delegate.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/metrics/profiler/ios/ios_tracking_synchronizer_delegate.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/metrics/profiler/tracking_synchronizer.h View 6 chunks +7 lines, -6 lines 0 comments Download
M components/metrics/profiler/tracking_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/profiler/tracking_synchronizer_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M components/metrics/serialization/metric_sample.h View 2 chunks +12 lines, -12 lines 0 comments Download
M components/metrics/serialization/metric_sample.cc View 1 chunk +19 lines, -19 lines 0 comments Download
M components/metrics/serialization/serialization_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics/serialization/serialization_utils.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M components/metrics/serialization/serialization_utils_unittest.cc View 6 chunks +12 lines, -11 lines 0 comments Download
M components/metrics/stability_metrics_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/test_metrics_service_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/test_metrics_service_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcheng
This is largely a search and replace. There's probably some IWYU errors (files that don't ...
4 years, 8 months ago (2016-04-21 21:09:08 UTC) #1
Mark P
I am not the right reviewer for this; I am not familiar with most of ...
4 years, 8 months ago (2016-04-21 21:17:49 UTC) #2
dcheng
On 2016/04/21 at 21:17:49, mpearson wrote: > I am not the right reviewer for this; ...
4 years, 8 months ago (2016-04-21 21:21:07 UTC) #4
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-04-21 21:29:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906173002/1
4 years, 8 months ago (2016-04-21 21:32:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 21:54:26 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:40:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d99c42a1a3c4566d5cdbac0bbbed5c266d09cfeb
Cr-Commit-Position: refs/heads/master@{#388913}

Powered by Google App Engine
This is Rietveld 408576698