components/metrics/net/network_metrics_provider.cc - Issue 1906173002: Convert //components/metrics from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/net/network_metrics_provider.cc

Issue 1906173002: Convert //components/metrics from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/metrics/net/network_metrics_provider.h ('k') | components/metrics/profiler/content/content_tracking_synchronizer_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/net/network_metrics_provider.cc

diff --git a/components/metrics/net/network_metrics_provider.cc b/components/metrics/net/network_metrics_provider.cc

index 925408939847bfd6c67e5555a1a6a9c962b44c88..aa83846b851b1f777fc90e409068af1cd730a265 100644

--- a/components/metrics/net/network_metrics_provider.cc

+++ b/components/metrics/net/network_metrics_provider.cc

@@ -249,7 +249,8 @@ void NetworkMetricsProvider::LogAggregatedMetrics() {

base::HistogramBase* error_codes = base::SparseHistogram::FactoryGet(

"Net.ErrorCodesForMainFrame3",

base::HistogramBase::kUmaTargetedHistogramFlag);

- scoped_ptr<base::HistogramSamples> samples = error_codes->SnapshotSamples();

+ std::unique_ptr<base::HistogramSamples> samples =

+ error_codes->SnapshotSamples();

base::HistogramBase::Count new_aborts =

samples->GetCount(-net::ERR_ABORTED) - total_aborts_;

base::HistogramBase::Count new_codes = samples->TotalCount() - total_codes_;