components/metrics/net/network_metrics_provider.h - Issue 1906173002: Convert //components/metrics from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/net/network_metrics_provider.h

Issue 1906173002: Convert //components/metrics from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/metrics/net/net_metrics_log_uploader_unittest.cc ('k') | components/metrics/net/network_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/net/network_metrics_provider.h

diff --git a/components/metrics/net/network_metrics_provider.h b/components/metrics/net/network_metrics_provider.h

index 5dbb5593b2491b0e358b6eeb1b3f72551b5c277a..da47689d2746187f5e7ba4e874a07c867327139b 100644

--- a/components/metrics/net/network_metrics_provider.h

+++ b/components/metrics/net/network_metrics_provider.h

@@ -5,8 +5,9 @@

#ifndef COMPONENTS_METRICS_NET_NETWORK_METRICS_PROVIDER_H_

#define COMPONENTS_METRICS_NET_NETWORK_METRICS_PROVIDER_H_

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "base/metrics/histogram_base.h"

#include "components/metrics/metrics_provider.h"

@@ -71,7 +72,7 @@ class NetworkMetricsProvider

net::WifiPHYLayerProtocol wifi_phy_layer_protocol_;

// Helper object for retrieving connected wifi access point information.

- scoped_ptr<WifiAccessPointInfoProvider> wifi_access_point_info_provider_;

+ std::unique_ptr<WifiAccessPointInfoProvider> wifi_access_point_info_provider_;

// These metrics track histogram totals for the Net.ErrorCodesForMainFrame3

// histogram. They are used to compute deltas at upload time.

« no previous file with comments | « components/metrics/net/net_metrics_log_uploader_unittest.cc ('k') | components/metrics/net/network_metrics_provider.cc » ('j') | no next file with comments »