components/metrics/leak_detector/leak_detector.h - Issue 1906173002: Convert //components/metrics from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/leak_detector/leak_detector.h

Issue 1906173002: Convert //components/metrics from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/metrics/leak_detector/call_stack_table_unittest.cc ('k') | components/metrics/leak_detector/leak_detector_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/leak_detector/leak_detector.h

diff --git a/components/metrics/leak_detector/leak_detector.h b/components/metrics/leak_detector/leak_detector.h

index 8fb265082a46784774aec93fda4579e6253f9fbc..12a0d1eb5c0064200915259fa3ab687581a6b610 100644

--- a/components/metrics/leak_detector/leak_detector.h

+++ b/components/metrics/leak_detector/leak_detector.h

@@ -9,12 +9,12 @@

#include <stdint.h>

#include <list>

+#include <memory>

#include <vector>

#include "base/feature_list.h"

#include "base/gtest_prod_util.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/observer_list.h"

#include "base/synchronization/lock.h"

#include "base/threading/thread_checker.h"

@@ -110,7 +110,7 @@ class LeakDetector {

// Handles leak detection logic. Must be called under lock as LeakDetectorImpl

// uses shared resources.

- scoped_ptr<leak_detector::LeakDetectorImpl> impl_;

+ std::unique_ptr<leak_detector::LeakDetectorImpl> impl_;

// For thread safety.

base::ThreadChecker thread_checker_;