LogDog: Add project namespace to Butler/Collector.

LogDog: Add project namespace to Butler/Collector.

BUG=

Committed: https://github.com/luci/luci-go/commit/2c89d7001680ffd3dfda2fdce6fabd6764933e88

[dnj, 2016-04-25 16:23:20]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org, iannucci@chromium.org, vadimsh@chromium.org

[dnj, 2016-04-25 16:23:20]

PTAL

[Vadim Sh., 2016-04-25 18:51:52]

lgtm with questions

https://codereview.chromium.org/1906023002/diff/20001/common/proto/logdog/log...
File common/proto/logdog/logpb/butler.proto (right):

https://codereview.chromium.org/1906023002/diff/20001/common/proto/logdog/log...
common/proto/logdog/logpb/butler.proto:131: but will not share the secret with a
client.
nit: add "* " :)

https://codereview.chromium.org/1906023002/diff/20001/common/proto/logdog/log...
common/proto/logdog/logpb/butler.proto:131: but will not share the secret with a
client.
also, who exactly is meant by "a client" here? Log consumers?

https://codereview.chromium.org/1906023002/diff/20001/common/proto/logdog/log...
common/proto/logdog/logpb/butler.proto:137: * This ensures that only the Butler
instance that generated the log stream
Is knowing secret alone sufficient to push messages to the stream?

Does it have an expiration time? Any bearer tokens should have short lifetime.

[dnj, 2016-04-25 19:30:26]

https://codereview.chromium.org/1906023002/diff/20001/common/proto/logdog/log...
File common/proto/logdog/logpb/butler.proto (right):

https://codereview.chromium.org/1906023002/diff/20001/common/proto/logdog/log...
common/proto/logdog/logpb/butler.proto:137: * This ensures that only the Butler
instance that generated the log stream
On 2016/04/25 18:51:52, Vadim Sh. wrote:
> Is knowing secret alone sufficient to push messages to the stream?
> 
> Does it have an expiration time? Any bearer tokens should have short lifetime.

The secret is:
- At the moment, generated by this Butler instance and used when registering
streams. The Coordinator will accept the secret of the first stream for a given
name and enforce that all messages associated with that stream match the secret.
- In the future, be generated by the Coordinator after a negotiation with the
Butler, and be valid until the stream prefix is closed, which will happen after
a fixed amount of time since its creation.

This is less a token and more a stream property. If you know the stream secret,
you are either a privileged internal service or the Butler instance that owns
the stream.

[dnj, 2016-04-30 03:22:39]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-04-30 03:22:39]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/1906023002/#ps60001
(title: "Rebase?")

[commit-bot: I haz the power, 2016-04-30 03:22:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906023002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906023002/60001

[commit-bot: I haz the power, 2016-04-30 03:30:19]

Description was changed from

==========
LogDog: Add project namespace to Butler/Collector.

BUG=
==========

to

==========
LogDog: Add project namespace to Butler/Collector.

BUG=

Committed:
https://github.com/luci/luci-go/commit/2c89d7001680ffd3dfda2fdce6fabd6764933e88
==========

[commit-bot: I haz the power, 2016-04-30 03:30:20]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-go/commit/2c89d7001680ffd3dfda2fdce6fabd6764933e88