Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1916813002: Annotee: Add project name support. (Closed)

Created:
4 years, 8 months ago by dnj
Modified:
4 years, 7 months ago
Reviewers:
iannucci, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://github.com/luci/luci-go@logdog-project-collector-butler
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Better URL generation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -37 lines) Patch
A client/cmd/logdog_annotee/link.go View 1 1 chunk +37 lines, -0 lines 0 comments Download
M client/cmd/logdog_annotee/main.go View 1 5 chunks +19 lines, -3 lines 0 comments Download
M client/logdog/annotee/processor.go View 1 6 chunks +19 lines, -34 lines 0 comments Download

Depends on Patchset:

Issue 1906023002 Patch 60001

Messages

Total messages: 9 (5 generated)
dnj
PTAL
4 years, 8 months ago (2016-04-25 16:22:32 UTC) #3
iannucci
lgtm
4 years, 7 months ago (2016-04-28 19:44:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916813002/40001
4 years, 7 months ago (2016-04-30 03:31:14 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 03:39:20 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://github.com/luci/luci-go/commit/90f25322ec04713458278479bd82ba675a77709a

Powered by Google App Engine
This is Rietveld 408576698