Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1916013002: LogDog: Add project namespacing to `logdog_cat` (Closed)

Created:
4 years, 8 months ago by dnj
Modified:
4 years, 7 months ago
Reviewers:
iannucci, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://github.com/luci/luci-go@logdog-project-collector-butler
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Add project namespacing to `logdog_cat` BUG= Committed: https://github.com/luci/luci-go/commit/6ccf01c6c0ae10ca2e15a48b722256eb7527c91a

Patch Set 1 #

Patch Set 2 : Rebase, project UI. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M client/cmd/logdog_cat/main.go View 1 6 chunks +13 lines, -2 lines 0 comments Download
M common/logdog/coordinator/client.go View 2 chunks +6 lines, -2 lines 0 comments Download
M common/logdog/coordinator/list.go View 1 chunk +1 line, -0 lines 0 comments Download
M common/logdog/coordinator/query.go View 1 chunk +1 line, -0 lines 0 comments Download
M common/logdog/coordinator/stream.go View 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1906023002 Patch 60001

Messages

Total messages: 8 (4 generated)
dnj
PTAL
4 years, 8 months ago (2016-04-25 16:22:40 UTC) #2
iannucci
lgtm
4 years, 7 months ago (2016-04-28 19:52:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916013002/20001
4 years, 7 months ago (2016-04-30 03:43:12 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 03:47:29 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/6ccf01c6c0ae10ca2e15a48b722256eb7527c91a

Powered by Google App Engine
This is Rietveld 408576698