Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1909053003: LogDog: Add project namespacing to Archivist. (Closed)

Created:
4 years, 8 months ago by dnj
Modified:
4 years, 7 months ago
Reviewers:
Ryan Tseng, iannucci, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://github.com/luci/luci-go@logdog-project-coordinator-logs
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Add project namespacing to Archivist. BUG= Committed: https://github.com/luci/luci-go/commit/7927fd8d65fa87f27ed191877078185a43fd0525

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -53 lines) Patch
M server/internal/logdog/archivist/archivist.go View 9 chunks +42 lines, -17 lines 0 comments Download
M server/internal/logdog/archivist/archivist_test.go View 17 chunks +71 lines, -34 lines 0 comments Download
M server/internal/logdog/archivist/storageSource.go View 3 chunks +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1909073002 Patch 40001

Dependent Patchsets:

Issue 1906023002 Patch 60001

Messages

Total messages: 12 (6 generated)
dnj
PTAL
4 years, 8 months ago (2016-04-25 16:24:39 UTC) #3
Ryan Tseng
lgtm https://codereview.chromium.org/1909053003/diff/1/server/internal/logdog/archivist/archivist.go File server/internal/logdog/archivist/archivist.go (right): https://codereview.chromium.org/1909053003/diff/1/server/internal/logdog/archivist/archivist.go#newcode362 server/internal/logdog/archivist/archivist.go:362: } elif project == "_", freak out? Or ...
4 years, 7 months ago (2016-04-28 19:57:35 UTC) #5
iannucci
lgtm
4 years, 7 months ago (2016-04-28 19:57:50 UTC) #6
dnj
https://codereview.chromium.org/1909053003/diff/1/server/internal/logdog/archivist/archivist.go File server/internal/logdog/archivist/archivist.go (right): https://codereview.chromium.org/1909053003/diff/1/server/internal/logdog/archivist/archivist.go#newcode362 server/internal/logdog/archivist/archivist.go:362: } On 2016/04/28 19:57:34, Ryan Tseng wrote: > elif ...
4 years, 7 months ago (2016-04-30 03:03:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909053003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909053003/40001
4 years, 7 months ago (2016-04-30 03:17:34 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 03:21:48 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://github.com/luci/luci-go/commit/7927fd8d65fa87f27ed191877078185a43fd0525

Powered by Google App Engine
This is Rietveld 408576698