Add ARC version to help and version pages

Add ARC version to help and version pages

TEST=deploy to samus with and without ARC
BUG=605624
Committed: https://crrev.com/1e751a476b07446d6be3fdbe920ec58b4338edd6
Cr-Commit-Position: refs/heads/master@{#389140}

[elijahtaylor1, 2016-04-21 19:08:29]

Description was changed from

==========
Add ARC version to help and version pages

TEST=deploy to samus with and without ARC
BUG=605624
==========

to

==========
Add ARC version to help and version pages

TEST=deploy to samus with and without ARC
BUG=605624
==========

[elijahtaylor1, 2016-04-21 19:08:30]

elijahtaylor@chromium.org changed reviewers:
+ stevenjb@chromium.org

[elijahtaylor1, 2016-04-21 19:08:58]

Hi Steven, PTAL at your convenience.

[stevenjb, 2016-04-21 19:38:55]

lgtm

https://codereview.chromium.org/1905113002/diff/1/chromeos/system/version_loa...
File chromeos/system/version_loader.cc (right):

https://codereview.chromium.org/1905113002/diff/1/chromeos/system/version_loa...
chromeos/system/version_loader.cc:69: version = "";
nit: not strictly necessary, version will not be set if GetLsbReleaseValue()
returns false.

https://codereview.chromium.org/1905113002/diff/1/components/version_ui/resou...
File components/version_ui/resources/about_version.js (right):

https://codereview.chromium.org/1905113002/diff/1/components/version_ui/resou...
components/version_ui/resources/about_version.js:50: $('arc_holder').hidden =
arcVersion == '';
nit: hidden = !arcVersion;

[elijahtaylor1, 2016-04-21 20:23:13]

https://codereview.chromium.org/1905113002/diff/1/chromeos/system/version_loa...
File chromeos/system/version_loader.cc (right):

https://codereview.chromium.org/1905113002/diff/1/chromeos/system/version_loa...
chromeos/system/version_loader.cc:69: version = "";
On 2016/04/21 19:38:54, stevenjb wrote:
> nit: not strictly necessary, version will not be set if GetLsbReleaseValue()
> returns false.

Done.

https://codereview.chromium.org/1905113002/diff/1/components/version_ui/resou...
File components/version_ui/resources/about_version.js (right):

https://codereview.chromium.org/1905113002/diff/1/components/version_ui/resou...
components/version_ui/resources/about_version.js:50: $('arc_holder').hidden =
arcVersion == '';
On 2016/04/21 19:38:54, stevenjb wrote:
> nit: hidden = !arcVersion;

Done.

[elijahtaylor1, 2016-04-22 01:07:43]

The CQ bit was checked by elijahtaylor@chromium.org

[elijahtaylor1, 2016-04-22 01:07:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1905113002/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-04-22 01:07:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905113002/20001

[commit-bot: I haz the power, 2016-04-22 01:20:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 01:20:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[elijahtaylor1, 2016-04-22 01:45:57]

elijahtaylor@chromium.org changed reviewers:
+ xiyuan@chromium.org

[elijahtaylor1, 2016-04-22 01:46:28]

apparently either git cl owners didn't identify all owners, or I messed up.

xiyuan, PTAL

[xiyuan, 2016-04-22 02:08:23]

lgtm

[elijahtaylor1, 2016-04-22 16:43:52]

The CQ bit was checked by elijahtaylor@chromium.org

[commit-bot: I haz the power, 2016-04-22 16:44:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905113002/20001

[commit-bot: I haz the power, 2016-04-22 16:48:26]

Description was changed from

==========
Add ARC version to help and version pages

TEST=deploy to samus with and without ARC
BUG=605624
==========

to

==========
Add ARC version to help and version pages

TEST=deploy to samus with and without ARC
BUG=605624
==========

[commit-bot: I haz the power, 2016-04-22 16:48:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:48:47]

Description was changed from

==========
Add ARC version to help and version pages

TEST=deploy to samus with and without ARC
BUG=605624
==========

to

==========
Add ARC version to help and version pages

TEST=deploy to samus with and without ARC
BUG=605624

Committed: https://crrev.com/1e751a476b07446d6be3fdbe920ec58b4338edd6
Cr-Commit-Position: refs/heads/master@{#389140}
==========

[commit-bot: I haz the power, 2016-04-22 19:48:48]

Patchset 2 (id:??) landed as
https://crrev.com/1e751a476b07446d6be3fdbe920ec58b4338edd6
Cr-Commit-Position: refs/heads/master@{#389140}