Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: chrome/browser/ui/webui/version_ui.cc

Issue 1905113002: Add ARC version to help and version pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/version_handler_chromeos.cc ('k') | chromeos/system/version_loader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/version_ui.h" 5 #include "chrome/browser/ui/webui/version_ui.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 51
52 // Localized and data strings. 52 // Localized and data strings.
53 html_source->AddLocalizedString(version_ui::kTitle, IDS_VERSION_UI_TITLE); 53 html_source->AddLocalizedString(version_ui::kTitle, IDS_VERSION_UI_TITLE);
54 html_source->AddLocalizedString(version_ui::kApplicationLabel, 54 html_source->AddLocalizedString(version_ui::kApplicationLabel,
55 IDS_PRODUCT_NAME); 55 IDS_PRODUCT_NAME);
56 html_source->AddString(version_ui::kVersion, 56 html_source->AddString(version_ui::kVersion,
57 version_info::GetVersionNumber()); 57 version_info::GetVersionNumber());
58 html_source->AddString(version_ui::kVersionModifier, 58 html_source->AddString(version_ui::kVersionModifier,
59 chrome::GetChannelString()); 59 chrome::GetChannelString());
60 html_source->AddLocalizedString(version_ui::kOSName, IDS_VERSION_UI_OS); 60 html_source->AddLocalizedString(version_ui::kOSName, IDS_VERSION_UI_OS);
61 html_source->AddLocalizedString(version_ui::kARC, IDS_ARC_LABEL);
61 html_source->AddLocalizedString(version_ui::kPlatform, IDS_PLATFORM_LABEL); 62 html_source->AddLocalizedString(version_ui::kPlatform, IDS_PLATFORM_LABEL);
62 html_source->AddString(version_ui::kOSType, version_info::GetOSType()); 63 html_source->AddString(version_ui::kOSType, version_info::GetOSType());
63 html_source->AddString(version_ui::kBlinkVersion, 64 html_source->AddString(version_ui::kBlinkVersion,
64 content::GetWebKitVersion()); 65 content::GetWebKitVersion());
65 html_source->AddString(version_ui::kJSEngine, "V8"); 66 html_source->AddString(version_ui::kJSEngine, "V8");
66 html_source->AddString(version_ui::kJSVersion, v8::V8::GetVersion()); 67 html_source->AddString(version_ui::kJSVersion, v8::V8::GetVersion());
67 68
68 #if defined(OS_ANDROID) 69 #if defined(OS_ANDROID)
69 html_source->AddString(version_ui::kOSVersion, 70 html_source->AddString(version_ui::kOSVersion,
70 AndroidAboutAppInfo::GetOsInfo()); 71 AndroidAboutAppInfo::GetOsInfo());
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 // Set up the chrome://theme/ source. 175 // Set up the chrome://theme/ source.
175 ThemeSource* theme = new ThemeSource(profile); 176 ThemeSource* theme = new ThemeSource(profile);
176 content::URLDataSource::Add(profile, theme); 177 content::URLDataSource::Add(profile, theme);
177 #endif 178 #endif
178 179
179 WebUIDataSource::Add(profile, CreateVersionUIDataSource()); 180 WebUIDataSource::Add(profile, CreateVersionUIDataSource());
180 } 181 }
181 182
182 VersionUI::~VersionUI() { 183 VersionUI::~VersionUI() {
183 } 184 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/version_handler_chromeos.cc ('k') | chromeos/system/version_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698