chrome/browser/ui/webui/version_handler_chromeos.h - Issue 1905113002: Add ARC version to help and version pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/version_handler_chromeos.h

Issue 1905113002: Add ARC version to help and version pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/version_handler_chromeos.h

diff --git a/chrome/browser/ui/webui/version_handler_chromeos.h b/chrome/browser/ui/webui/version_handler_chromeos.h

index b12b7a89141a64cfa7e3fc672e602071a5607612..2a9a9fea37fef7cf7263cb570942e0e666f81227 100644

--- a/chrome/browser/ui/webui/version_handler_chromeos.h

+++ b/chrome/browser/ui/webui/version_handler_chromeos.h

@@ -22,8 +22,9 @@ class VersionHandlerChromeOS : public VersionHandler {

// VersionHandler overrides:

void HandleRequestVersionInfo(const base::ListValue* args) override;

- // Callback from chromeos::VersionLoader giving the version.

+ // Callbacks from chromeos::VersionLoader.

void OnVersion(const std::string& version);

+ void OnARCVersion(const std::string& version);

private:

base::WeakPtrFactory<VersionHandlerChromeOS> weak_factory_;