Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: components/version_ui/resources/about_version.js

Issue 1905113002: Add ARC version to help and version pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/version_ui/resources/about_version.html ('k') | components/version_ui/version_ui_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_ui/resources/about_version.js
diff --git a/components/version_ui/resources/about_version.js b/components/version_ui/resources/about_version.js
index 476311bfae9837eed6419c27409ddf6eab078d8a..c335b6360cd8f58fdfb33b187ceea223db923bc0 100644
--- a/components/version_ui/resources/about_version.js
+++ b/components/version_ui/resources/about_version.js
@@ -40,9 +40,20 @@ function returnOsVersion(osVersion) {
$('os_version').textContent = osVersion;
}
+
+/**
+ * Callback from the backend with the ARC version to display.
+ * @param {string} arcVersion The ARC version to display.
+ */
+function returnARCVersion(arcVersion) {
+ $('arc_version').textContent = arcVersion;
+ $('arc_holder').hidden = !arcVersion;
+}
+
/* All the work we do onload. */
function onLoadWork() {
chrome.send('requestVersionInfo');
+ $('arc_holder').hidden = true;
}
document.addEventListener('DOMContentLoaded', onLoadWork);
« no previous file with comments | « components/version_ui/resources/about_version.html ('k') | components/version_ui/version_ui_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698