Change SupportsSpdy dict, SpdySettingsMap, ServerNetworkStatsMap, AlternativeServiceMap and disk da…

Change SupportsSpdy dict, SpdySettingsMap, ServerNetworkStatsMap, AlternativeServiceMap and disk data to use scheme/host/port as keys. Previously we dropped down and ignored the scheme when processing those data.

BUG=600804
Committed: https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d
Cr-Commit-Position: refs/heads/master@{#389227}

[Zhongyi Shi, 2016-04-19 20:52:39]

Description was changed from

==========
Change SupportsSpdy dict, SpdySettingsMap, ServerNetworkStatsMap,
AlternativeServiceMap and disk data to use scheme/host/port as keys. Previously
we dropped down and ignored the scheme when processing those data.

BUG=600804
==========

to

==========
Change SupportsSpdy dict, SpdySettingsMap, ServerNetworkStatsMap,
AlternativeServiceMap and disk data to use scheme/host/port as keys. Previously
we dropped down and ignored the scheme when processing those data.

BUG=600804
==========

[Zhongyi Shi, 2016-04-19 20:52:39]

zhongyi@chromium.org changed reviewers:
+ memenke@chromium.org, rch@chromium.org

[Zhongyi Shi, 2016-04-19 20:55:03]

zhongyi@chromium.org changed reviewers:
+ mmenke@chromium.org
- memenke@chromium.org

[Zhongyi Shi, 2016-04-19 20:56:08]

This is the landing CL, PTAL! Thanks :D

For detailed review, please refer to the following:

SHP 5: Add a new version for disk data, migrating disk data to use
scheme/host/port representation as keys.
https://codereview.chromium.org/1892813003#ps40001

SHP 4: Change AlternativeServiceMap to use SchemeHostPort as the key. No change
to disk data.
https://codereview.chromium.org/1878143005#ps90001

SHP 3: Change ServerNetworkStatsMap to use SchemeHostPort as the key. No change
to disk data.
https://codereview.chromium.org/1878273004#ps60001

SHP 2: Change SpdySettingsMap to use SchemeHostPort as the key. No change to
disk data.
https://codereview.chromium.org/1866983006#ps160001

SHP 1: Change SupportsSpdy dict to use SchemeHostPort as the key. No change to
disk data.
https://codereview.chromium.org/1860343002/

[mmenke, 2016-04-21 18:52:34]

loader/, cronet/ LGTM

https://codereview.chromium.org/1904483004/diff/20001/components/cronet/andro...
File components/cronet/android/url_request_context_adapter.cc (right):

https://codereview.chromium.org/1904483004/diff/20001/components/cronet/andro...
components/cronet/android/url_request_context_adapter.cc:199:
url::SchemeHostPort quic_server("https", canon_host, quic_hint.port);
include url/scheme_host_port.h

https://codereview.chromium.org/1904483004/diff/20001/components/cronet/ios/c...
File components/cronet/ios/cronet_environment.cc (right):

https://codereview.chromium.org/1904483004/diff/20001/components/cronet/ios/c...
components/cronet/ios/cronet_environment.cc:330: url::SchemeHostPort
quic_hint_server("https", quic_hint.host(),
include url/scheme_host_port.h

https://codereview.chromium.org/1904483004/diff/20001/content/browser/loader/...
File content/browser/loader/resource_scheduler_unittest.cc (right):

https://codereview.chromium.org/1904483004/diff/20001/content/browser/loader/...
content/browser/loader/resource_scheduler_unittest.cc:340:
url::SchemeHostPort("https", "spdyhost", 443), true);
include url/scheme_host_port.h

[Zhongyi Shi, 2016-04-21 19:44:29]

Thanks for reviewing the cronet/ and load/, Matt :D

Ryan, can you take a final look on this landing CL? Can't wait to see this being
shipped to chromium. \O/

https://codereview.chromium.org/1904483004/diff/20001/components/cronet/andro...
File components/cronet/android/url_request_context_adapter.cc (right):

https://codereview.chromium.org/1904483004/diff/20001/components/cronet/andro...
components/cronet/android/url_request_context_adapter.cc:199:
url::SchemeHostPort quic_server("https", canon_host, quic_hint.port);
On 2016/04/21 18:52:34, mmenke wrote:
> include url/scheme_host_port.h

Done.

https://codereview.chromium.org/1904483004/diff/20001/components/cronet/ios/c...
File components/cronet/ios/cronet_environment.cc (right):

https://codereview.chromium.org/1904483004/diff/20001/components/cronet/ios/c...
components/cronet/ios/cronet_environment.cc:330: url::SchemeHostPort
quic_hint_server("https", quic_hint.host(),
On 2016/04/21 18:52:34, mmenke wrote:
> include url/scheme_host_port.h

Done.

https://codereview.chromium.org/1904483004/diff/20001/content/browser/loader/...
File content/browser/loader/resource_scheduler_unittest.cc (right):

https://codereview.chromium.org/1904483004/diff/20001/content/browser/loader/...
content/browser/loader/resource_scheduler_unittest.cc:340:
url::SchemeHostPort("https", "spdyhost", 443), true);
On 2016/04/21 18:52:34, mmenke wrote:
> include url/scheme_host_port.h

Done.

[Ryan Hamilton, 2016-04-22 17:57:03]

lgtm, thanks for doing this!

[Zhongyi Shi, 2016-04-22 18:15:27]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2016-04-22 18:15:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1904483004/#ps40001
(title: "add includes")

[commit-bot: I haz the power, 2016-04-22 18:16:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904483004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904483004/40001

[commit-bot: I haz the power, 2016-04-22 18:20:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 18:20:31]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Zhongyi Shi, 2016-04-22 18:30:21]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2016-04-22 18:30:21]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org,
mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1904483004/#ps60001
(title: "sync")

[commit-bot: I haz the power, 2016-04-22 18:31:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904483004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904483004/60001

[commit-bot: I haz the power, 2016-04-22 18:44:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 18:44:03]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Zhongyi Shi, 2016-04-22 19:14:31]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2016-04-22 19:14:31]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org,
mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1904483004/#ps80001
(title: "fix compile after sync code, introduced by commit 388755")

[commit-bot: I haz the power, 2016-04-22 19:15:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904483004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904483004/80001

[commit-bot: I haz the power, 2016-04-22 20:36:56]

Description was changed from

==========
Change SupportsSpdy dict, SpdySettingsMap, ServerNetworkStatsMap,
AlternativeServiceMap and disk data to use scheme/host/port as keys. Previously
we dropped down and ignored the scheme when processing those data.

BUG=600804
==========

to

==========
Change SupportsSpdy dict, SpdySettingsMap, ServerNetworkStatsMap,
AlternativeServiceMap and disk data to use scheme/host/port as keys. Previously
we dropped down and ignored the scheme when processing those data.

BUG=600804
==========

[commit-bot: I haz the power, 2016-04-22 20:36:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-22 20:38:02]

Description was changed from

==========
Change SupportsSpdy dict, SpdySettingsMap, ServerNetworkStatsMap,
AlternativeServiceMap and disk data to use scheme/host/port as keys. Previously
we dropped down and ignored the scheme when processing those data.

BUG=600804
==========

to

==========
Change SupportsSpdy dict, SpdySettingsMap, ServerNetworkStatsMap,
AlternativeServiceMap and disk data to use scheme/host/port as keys. Previously
we dropped down and ignored the scheme when processing those data.

BUG=600804

Committed: https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d
Cr-Commit-Position: refs/heads/master@{#389227}
==========

[commit-bot: I haz the power, 2016-04-22 20:38:04]

Patchset 5 (id:??) landed as
https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d
Cr-Commit-Position: refs/heads/master@{#389227}