SHP 2: Change SpdySettingsMap to use SchemeHostPort as the key. No change to Pref data.

SHP 2: Change SpdySettingsMap to use SchemeHostPort as the key. No change to Pref data.
Hardcoded to always add "https" as scheme when loading from Pref to Cache, always drop scheme when write to Pref from Cache.

Review only, should be landed in final unified CL.

BUG=600804

[Zhongyi Shi, 2016-04-08 04:04:03]

zhongyi@chromium.org changed reviewers:
+ rch@chromium.org

[Zhongyi Shi, 2016-04-08 04:04:03]

Migrating SpdySettingsMap to use SHP.

[Ryan Hamilton, 2016-04-08 18:38:05]

Any idea what's up with the red bots?

Looks good, though.

https://codereview.chromium.org/1866983006/diff/1/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

https://codereview.chromium.org/1866983006/diff/1/net/spdy/spdy_session.h#new...
net/spdy/spdy_session.h:407: url::SchemeHostPort GetSpdyServer();
nit: No need for Spdy in this method name. Can you also add a comment?

[Zhongyi Shi, 2016-04-08 21:53:20]

On 2016/04/08 18:38:05, Ryan Hamilton wrote:
> Any idea what's up with the red bots?
> 
> Looks good, though.
> 
> https://codereview.chromium.org/1866983006/diff/1/net/spdy/spdy_session.h
> File net/spdy/spdy_session.h (right):
> 
>
https://codereview.chromium.org/1866983006/diff/1/net/spdy/spdy_session.h#new...
> net/spdy/spdy_session.h:407: url::SchemeHostPort GetSpdyServer();
> nit: No need for Spdy in this method name. Can you also add a comment?

Cauz this patch is not synced with the latest code and got a patch failure. I
have did a sync on SHP1 and SHP2, it should fix the red bots.

[Zhongyi Shi, 2016-04-11 22:31:18]

Patchset #4 (id:60001) has been deleted

[Zhongyi Shi, 2016-04-11 22:31:30]

Patchset #4 (id:80001) has been deleted

[Zhongyi Shi, 2016-04-12 21:08:08]

https://codereview.chromium.org/1866983006/diff/1/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

https://codereview.chromium.org/1866983006/diff/1/net/spdy/spdy_session.h#new...
net/spdy/spdy_session.h:407: url::SchemeHostPort GetSpdyServer();
On 2016/04/08 18:38:05, Ryan Hamilton wrote:
> nit: No need for Spdy in this method name. Can you also add a comment?

Done.

https://codereview.chromium.org/1866983006/diff/120001/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/1866983006/diff/120001/net/spdy/spdy_session....
net/spdy/spdy_session.cc:2042: return url::SchemeHostPort(is_secure_ ? "https" :
"http",
Need confirm: is that safe to use is_secure_ instead of calling GetSSLInfo()?

https://code.google.com/p/chromium/codesearch#chromium/src/net/spdy/spdy_sess...

[Zhongyi Shi, 2016-04-13 00:39:42]

Description was changed from

==========
SHP 2: Change SpdySettingsMap to use SchemeHostPort as the key. No change to
Pref data.
Hardcoded to always add "http" as scheme when loading from Pref to Cache, always
drop scheme when write to Pref from Cache.

Review only, should be landed in final unified CL.

BUG=600804
==========

to

==========
SHP 2: Change SpdySettingsMap to use SchemeHostPort as the key. No change to
Pref data.
Hardcoded to always add "https" as scheme when loading from Pref to Cache,
always drop scheme when write to Pref from Cache.

Review only, should be landed in final unified CL.

BUG=600804
==========

[Ryan Hamilton, 2016-04-13 04:13:24]

https://codereview.chromium.org/1866983006/diff/120001/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/1866983006/diff/120001/net/spdy/spdy_session....
net/spdy/spdy_session.cc:2042: return url::SchemeHostPort(is_secure_ ? "https" :
"http",
On 2016/04/12 21:08:08, Zhongyi Shi wrote:
> Need confirm: is that safe to use is_secure_ instead of calling GetSSLInfo()?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/net/spdy/spdy_sess...

Looks great!