SHP 5: Adding a new version for disk data, migrating disk data to use scheme/host/port representati…

SHP 5: Adding a new version for disk data, migrating disk data to use scheme/host/port representation as keys. Review only, will be landed together in the final CL

BUG=600804

[Zhongyi Shi, 2016-04-15 21:56:57]

Description was changed from

==========
SHP_5: Adding a new version for disk data, migrating disk data to use
scheme/host/port representation as keys. Review only, will be landed together in
the final CL

BUG=600804
==========

to

==========
SHP 5: Adding a new version for disk data, migrating disk data to use
scheme/host/port representation as keys. Review only, will be landed together in
the final CL

BUG=600804
==========

[Zhongyi Shi, 2016-04-15 21:56:57]

zhongyi@chromium.org changed reviewers:
+ rch@chromium.org, rtenneti@chromium.org

[Zhongyi Shi, 2016-04-15 21:57:41]

Very last CL of this SHP series. Migrating disk data, protected by new version
number = 5. ptal!

[Ryan Hamilton, 2016-04-18 17:33:46]

Sweet. Looks pretty good. I definitely look forward to hearing what Raman says
since he's the most familiar with this code.

To confirm, have you removed all the TODOs from previous CLs?

https://codereview.chromium.org/1892813003/diff/1/net/http/http_server_proper...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/1892813003/diff/1/net/http/http_server_proper...
net/http/http_server_properties_manager.cc:493: //         
{"http:0.client-channel.google.com:443" : {...}},
should this be :// instead of : ? (and below)

[Zhongyi Shi, 2016-04-18 19:54:38]

Grepped my ldap in the code, yup, I am sure all the ToDos are removed :D

https://codereview.chromium.org/1892813003/diff/1/net/http/http_server_proper...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/1892813003/diff/1/net/http/http_server_proper...
net/http/http_server_properties_manager.cc:493: //         
{"http:0.client-channel.google.com:443" : {...}},
On 2016/04/18 17:33:45, Ryan Hamilton wrote:
> should this be :// instead of : ? (and below)

yeah, sorry for those typos.

[ramant (doing other things), 2016-04-18 21:31:14]

Hi Ryan and Zhongyi,
  These changes LGTM.

thanks
raman

[Ryan Hamilton, 2016-04-18 21:58:22]

lgtm too