Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1892813003: SHP 5: Adding a new version for disk data, migrating disk data to use scheme/host/port representati… (Closed)

Created:
4 years, 8 months ago by Zhongyi Shi
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@SHP_4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SHP 5: Adding a new version for disk data, migrating disk data to use scheme/host/port representation as keys. Review only, will be landed together in the final CL BUG=600804

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync to SHP_4 changes, update a comment typo #

Patch Set 3 : git sync #

Patch Set 4 : git sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -72 lines) Patch
M net/http/http_server_properties_manager.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_server_properties_manager.cc View 1 2 12 chunks +39 lines, -28 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 1 2 12 chunks +74 lines, -43 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Zhongyi Shi
Very last CL of this SHP series. Migrating disk data, protected by new version number ...
4 years, 8 months ago (2016-04-15 21:57:41 UTC) #3
Ryan Hamilton
Sweet. Looks pretty good. I definitely look forward to hearing what Raman says since he's ...
4 years, 8 months ago (2016-04-18 17:33:46 UTC) #4
Zhongyi Shi
Grepped my ldap in the code, yup, I am sure all the ToDos are removed ...
4 years, 8 months ago (2016-04-18 19:54:38 UTC) #5
ramant (doing other things)
Hi Ryan and Zhongyi, These changes LGTM. thanks raman
4 years, 8 months ago (2016-04-18 21:31:14 UTC) #6
Ryan Hamilton
4 years, 8 months ago (2016-04-18 21:58:22 UTC) #7
lgtm too

Powered by Google App Engine
This is Rietveld 408576698