Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1878273004: SHP 3: Change ServerNetworkStatsMap to use SchemeHostPort as the key. No change to Pref data. (Closed)

Created:
4 years, 8 months ago by Zhongyi Shi
Modified:
4 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SHP 3: Change ServerNetworkStatsMap to use SchemeHostPort as the key. No change to Pref data. Hardcoded to always add "https" as scheme when loading from Pref to Cache, always drop scheme when write to Pref from Cache. Review only, should be landed in final unified CL. BUG=600804

Patch Set 1 : #

Patch Set 2 : git sync #

Patch Set 3 : git sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -48 lines) Patch
M net/http/http_server_properties.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 2 4 chunks +14 lines, -10 lines 0 comments Download
M net/http/http_server_properties_manager.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 1 2 5 chunks +14 lines, -11 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 1 2 8 chunks +11 lines, -9 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (3 generated)
Zhongyi Shi
4 years, 8 months ago (2016-04-13 00:37:51 UTC) #4
Ryan Hamilton
4 years, 8 months ago (2016-04-13 04:10:55 UTC) #5
looks good

Powered by Google App Engine
This is Rietveld 408576698