Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1904163002: Move Web Notifications to use Mojo

Created:
4 years, 8 months ago by Peter Beverloo
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, haraken, jam, kinuko+watch, mlamouri+watch-notifications_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@skbitmap-blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] Move Web Notifications to use Mojo This is not ready for review. BUG=561879

Patch Set 1 #

Patch Set 2 : removes cruft #

Patch Set 3 : resolves the promise #

Total comments: 1

Patch Set 4 : most of the blink side done #

Patch Set 5 : page notifications work #

Patch Set 6 : BlinkNotificationServiceImpl to live on the IO thread #

Patch Set 7 : implementation largely finished, threading issues #

Patch Set 8 : it works \o/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1645 lines, -2277 lines) Patch
M WATCHLISTS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 1 chunk +2 lines, -1 line 0 comments Download
A content/browser/notifications/blink_notification_service_impl.h View 1 2 3 4 5 6 1 chunk +129 lines, -0 lines 0 comments Download
A content/browser/notifications/blink_notification_service_impl.cc View 1 2 3 4 5 6 7 1 chunk +319 lines, -0 lines 0 comments Download
M content/browser/notifications/notification_event_dispatcher_impl.cc View 1 2 3 4 5 6 4 chunks +54 lines, -12 lines 0 comments Download
M content/browser/notifications/notification_id_generator.cc View 1 2 3 4 5 6 7 4 chunks +14 lines, -9 lines 0 comments Download
D content/browser/notifications/notification_message_filter.h View 1 2 3 4 1 chunk +0 lines, -132 lines 0 comments Download
D content/browser/notifications/notification_message_filter.cc View 1 2 3 4 1 chunk +0 lines, -346 lines 0 comments Download
M content/browser/notifications/page_notification_delegate.h View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/notifications/page_notification_delegate.cc View 1 2 3 4 1 chunk +9 lines, -29 lines 0 comments Download
M content/browser/notifications/platform_notification_context_impl.h View 1 2 3 4 5 6 chunks +23 lines, -0 lines 0 comments Download
M content/browser/notifications/platform_notification_context_impl.cc View 1 2 3 4 5 2 chunks +35 lines, -0 lines 0 comments Download
M content/browser/notifications/type_converters.h View 1 2 3 4 2 chunks +10 lines, -1 line 0 comments Download
M content/browser/notifications/type_converters.cc View 1 2 3 4 2 chunks +19 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 3 chunks +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M content/child/blink_platform_impl.h View 1 2 3 4 5 6 3 chunks +0 lines, -3 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 4 5 6 3 chunks +0 lines, -14 lines 0 comments Download
M content/child/child_thread_impl.h View 1 3 chunks +0 lines, -7 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
D content/child/notifications/OWNERS View 1 1 chunk +0 lines, -4 lines 0 comments Download
D content/child/notifications/PRESUBMIT.py View 1 1 chunk +0 lines, -12 lines 0 comments Download
D content/child/notifications/notification_data_conversions.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D content/child/notifications/notification_data_conversions.cc View 1 1 chunk +0 lines, -130 lines 0 comments Download
D content/child/notifications/notification_data_conversions_unittest.cc View 1 1 chunk +0 lines, -246 lines 0 comments Download
D content/child/notifications/notification_dispatcher.h View 1 1 chunk +0 lines, -45 lines 0 comments Download
D content/child/notifications/notification_dispatcher.cc View 1 1 chunk +0 lines, -54 lines 0 comments Download
D content/child/notifications/notification_manager.h View 1 1 chunk +0 lines, -102 lines 0 comments Download
D content/child/notifications/notification_manager.cc View 1 1 chunk +0 lines, -309 lines 0 comments Download
M content/child/service_worker/web_service_worker_registration_impl.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/child/service_worker/web_service_worker_registration_impl.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/content_message_generator.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
A content/common/notification_service_worker_client.mojom View 1 2 3 4 5 6 1 chunk +20 lines, -0 lines 0 comments Download
D content/common/platform_notification_messages.h View 1 2 3 4 1 chunk +0 lines, -132 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 2 3 4 3 chunks +0 lines, -16 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_child.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 2 3 4 5 6 3 chunks +23 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/mojo/blink_service_registry_impl.h View 1 2 3 4 5 6 7 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/mojo/blink_service_registry_impl.cc View 1 2 3 4 5 6 7 1 chunk +13 lines, -1 line 0 comments Download
A content/renderer/notifications/notification_service_worker_client_impl.h View 1 2 3 4 5 6 1 chunk +45 lines, -0 lines 0 comments Download
A content/renderer/notifications/notification_service_worker_client_impl.cc View 1 2 3 4 5 6 1 chunk +78 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 2 3 4 5 6 4 chunks +13 lines, -13 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 2 3 4 5 6 7 13 chunks +79 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/modules/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.h View 1 2 3 4 7 chunks +22 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 2 3 4 5 6 7 9 chunks +80 lines, -92 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationData.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationData.cpp View 1 2 3 4 5 6 7 1 chunk +48 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp View 1 2 3 4 10 chunks +50 lines, -49 lines 0 comments Download
A third_party/WebKit/Source/modules/notifications/NotificationManager.h View 1 2 3 4 5 6 7 1 chunk +85 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/notifications/NotificationManager.cpp View 1 2 3 4 5 6 7 1 chunk +115 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h View 1 2 3 4 2 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp View 1 2 3 4 4 chunks +22 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationResourcesLoaderTest.cpp View 1 2 3 4 11 chunks +91 lines, -57 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h View 1 2 3 4 3 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 2 3 4 5 6 5 chunks +59 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 3 4 5 6 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/web.gyp View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/public/platform/DEPS View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
D third_party/WebKit/public/platform/modules/notifications/WebNotificationAction.h View 1 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/public/platform/modules/notifications/WebNotificationData.h View 1 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/public/platform/modules/notifications/WebNotificationDelegate.h View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h View 1 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/public/platform/modules/notifications/WebNotificationResources.h View 1 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/public/platform/modules/notifications/notification.mojom View 1 2 3 4 5 6 7 4 chunks +12 lines, -6 lines 0 comments Download
A third_party/WebKit/public/platform/modules/notifications/notification_resources.mojom View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/notifications/notification_service.mojom View 1 2 3 4 5 6 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h View 1 2 3 4 3 chunks +10 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1906773003 Patch 20001

Messages

Total messages: 13 (7 generated)
whywhat
lgtm
4 years, 8 months ago (2016-04-22 18:40:02 UTC) #2
dcheng
https://codereview.chromium.org/1904163002/diff/40001/third_party/WebKit/public/platform/modules/notifications/notification_service.mojom File third_party/WebKit/public/platform/modules/notifications/notification_service.mojom (right): https://codereview.chromium.org/1904163002/diff/40001/third_party/WebKit/public/platform/modules/notifications/notification_service.mojom#newcode1 third_party/WebKit/public/platform/modules/notifications/notification_service.mojom:1: // Copyright 2016 The Chromium Authors. All rights reserved. ...
4 years, 8 months ago (2016-04-22 18:40:50 UTC) #4
haraken
4 years, 8 months ago (2016-04-22 18:41:36 UTC) #6
Peter Beverloo
On 2016/04/22 18:40:50, dcheng wrote: > https://codereview.chromium.org/1904163002/diff/40001/third_party/WebKit/public/platform/modules/notifications/notification_service.mojom > File > third_party/WebKit/public/platform/modules/notifications/notification_service.mojom > (right): > > ...
4 years, 8 months ago (2016-04-22 18:42:18 UTC) #7
dcheng
On 2016/04/22 at 18:42:18, peter wrote: > On 2016/04/22 18:40:50, dcheng wrote: > > https://codereview.chromium.org/1904163002/diff/40001/third_party/WebKit/public/platform/modules/notifications/notification_service.mojom ...
4 years, 8 months ago (2016-04-22 18:43:23 UTC) #9
Peter Beverloo
4 years, 8 months ago (2016-04-22 18:43:57 UTC) #10 
To clarify once more - this CL is not intended for landing and is just where I
iterate on the work until it's done. I'll send it out once ready :-).

(Anton's approval is to be ignored.)

Powered by Google App Engine
This is Rietveld 408576698