third_party/WebKit/Source/modules/notifications/NotificationData.h - Issue 1904163002: Move Web Notifications to use Mojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationData.h

Issue 1904163002: Move Web Notifications to use Mojo Base URL: https://chromium.googlesource.com/chromium/src.git@skbitmap-blink

Patch Set: it works \o/ Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/Notification.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationData.h

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationData.h b/third_party/WebKit/Source/modules/notifications/NotificationData.h

index 09b3a66baca5a38d613df9318e0e7b0d30f32801..bee6479697b0013a462c5c9fb4036acd41c4048a 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationData.h

+++ b/third_party/WebKit/Source/modules/notifications/NotificationData.h

@@ -6,7 +6,7 @@

#define NotificationData_h

#include "modules/ModulesExport.h"

-#include "public/platform/modules/notifications/WebNotificationData.h"

+#include "public/platform/modules/notifications/notification.mojom-blink.h"

namespace WTF {

class String;

@@ -18,9 +18,9 @@ class ExceptionState;

class ExecutionContext;

class NotificationOptions;

-// Creates a WebNotificationData object based on the developer-provided notification data. When the

+// Creates a Mojo Notification object based on the developer-provided notification data. When the

// data is deemed invalid, an exception will be thrown to the passed exception state.

-MODULES_EXPORT WebNotificationData createWebNotificationData(ExecutionContext*, const String& title, const NotificationOptions&, ExceptionState&);

+MODULES_EXPORT mojom::blink::NotificationPtr createNotificationData(ExecutionContext*, const String& title, const NotificationOptions&, ExceptionState&);

} // namespace blink