Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1906773003: Enable SkBitmap to be used by Mojo in Blink (Closed)

Created:
4 years, 8 months ago by Peter Beverloo
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, blink-reviews-api_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dglazkov+blink, blink-reviews, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, sadrul, darin (slow to review), ben+mojo_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable SkBitmap to be used by Mojo in Blink This CL moves the bitmap.mojom file to Blink, keeps the regular converters in //skia/public/ and introduces converters for the WTF variant of the generated mojom file in Blink's platform directory. In this, the type converters had to be duplicated. It would be grand if we can find a way to avoid that. BUG=605107

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -159 lines) Patch
M chrome/browser/image_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/image_decoder.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/image_decoder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/image_decoder_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/utility/image_decoder_impl_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/image_downloader/image_downloader.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/image_downloader/image_downloader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/shelf/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/shelf/public/interfaces/shelf.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M skia/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D skia/public/interfaces/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D skia/public/interfaces/bitmap.mojom View 1 chunk +0 lines, -43 lines 0 comments Download
M skia/public/type_converters.h View 1 chunk +5 lines, -5 lines 0 comments Download
M skia/public/type_converters.cc View 5 chunks +34 lines, -34 lines 0 comments Download
M skia/skia.gyp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/bitmap_type_converters.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/bitmap_type_converters.cc View 5 chunks +38 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/public/platform/bitmap.mojom View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 1 (1 generated)
Peter Beverloo
4 years, 8 months ago (2016-04-21 17:58:30 UTC) #1 
Description was changed from

==========
Enable SkBitmap to be used by Mojo in Blink

This CL moves the bitmap.mojom file to Blink, keeps the regular
converters in //skia/public/ and introduces converters for the WTF
variant of the generated mojom file in Blink's platform directory.

BUG=605107
==========

to

==========
Enable SkBitmap to be used by Mojo in Blink

This CL moves the bitmap.mojom file to Blink, keeps the regular
converters in //skia/public/ and introduces converters for the WTF
variant of the generated mojom file in Blink's platform directory.

In this, the type converters had to be duplicated. It would be
grand if we can find a way to avoid that.

BUG=605107
==========

Powered by Google App Engine
This is Rietveld 408576698