Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: third_party/WebKit/public/platform/modules/notifications/notification.mojom

Issue 1904163002: Move Web Notifications to use Mojo Base URL: https://chromium.googlesource.com/chromium/src.git@skbitmap-blink
Patch Set: it works \o/ Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/notifications/notification.mojom
diff --git a/third_party/WebKit/public/platform/modules/notifications/notification.mojom b/third_party/WebKit/public/platform/modules/notifications/notification.mojom
index b969e47eb010b76fa97c8e03afff9b838f430a53..381c79c03d2009ef09918e834202df3eb947281e 100644
--- a/third_party/WebKit/public/platform/modules/notifications/notification.mojom
+++ b/third_party/WebKit/public/platform/modules/notifications/notification.mojom
@@ -22,7 +22,7 @@ struct NotificationAction {
string title;
// URL of the icon for the button. May be empty if no url was specified.
- string icon;
+ string? icon;
// Placeholder to display for text-based actions in absence of user input.
string? placeholder;
@@ -42,6 +42,12 @@ struct Notification {
// the |data| property of this structure.
const int32 kMaximumDeveloperDataBytes = 1048576; // 1MB
+ // Id of the notification, provided by the embedder.
+ string? id;
+
+ // Origin for which the notification was shown, provided by the embedder.
+ string? origin;
+
// Title to be displayed with the Web Notification.
string title;
@@ -59,14 +65,14 @@ struct Notification {
string tag;
// URL of the icon which is to be displayed with the notification.
- string icon;
+ string? icon;
// URL of the badge representing the website displaying the notification.
- string badge;
+ string? badge;
// Vibration pattern for the notification, following the syntax of the
// Vibration API. https://w3c.github.io/vibration/
- array<uint32> vibration_pattern;
+ array<uint32>? vibration_pattern;
// The time at which the event the notification represents took place.
double timestamp;
@@ -85,8 +91,8 @@ struct Notification {
// Developer-provided data associated with the notification, in the form of
// a serialized string. Must not exceed |kMaximumDeveloperDataBytes| bytes.
- array<int8> data;
+ array<int8>? data;
// Actions that should be shown as buttons on the notification.
- array<NotificationAction> actions;
+ array<NotificationAction>? actions;
};

Powered by Google App Engine
This is Rietveld 408576698