Reflect recent spec changes to V8 Extra ReadableStream impl

Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=503491, 608259
R=domenic,yhirano

Committed: https://crrev.com/b2496216b74c6d5872871c933a046340fc1fe7cf
Cr-Commit-Position: refs/heads/master@{#392058}

[tyoshino (SeeGerritForStatus), 2016-04-27 09:02:30]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 09:02:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902673003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902673003/80001

[tyoshino (SeeGerritForStatus), 2016-04-27 09:38:12]

Description was changed from

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

BUG=none
==========

to

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-04-27 09:38:12]

tyoshino@chromium.org changed reviewers:
+ domenic@chromium.org, yhirano@chromium.org

[tyoshino (SeeGerritForStatus), 2016-04-27 09:39:00]

Description was changed from

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

BUG=none
==========

to

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-04-27 09:39:14]

yhirano: Please review
domenic: FYI.

[tyoshino (SeeGerritForStatus), 2016-04-27 10:17:43]

Forgot to upload ps after some reordering. Please take a look at ps6

[domenic, 2016-04-27 21:12:24]

The change to no longer use null controller needs more work on the C++ side, I
am pretty sure. I noted in my line comments.

It is a bit sad that we no longer get to avoid the controller overhead, but I
guess since so much logic is in the controller now it makes sense that we need
to keep it.

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:28: const
readableStreamBits = v8.createPrivateSymbol('bit field for [[disturbed]]');
It's a bit unfortunate that we need a whole new 64 bits or so just for this. Is
it possible to move it into the readableStreamDefaultControllerBits, with a
comment saying that that's not how the spec works but we're doing it for
efficiency?

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:86: const
errEnqueueClosedStream = 'Cannot enqueue a closed readable stream';
"Cannot enqueue a chunk into a closed readable stream"

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:87: const
errEnqueueErroredStream = 'Cannot enqueue an errored readable stream';
"Cannot enqueue a chunk into an errored readable stream"

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:93: const
errGetReaderNotByteStream = 'Cannot get a ReadableStreamBYOBReader for a stream
not constructed with a byte source';
"This readable stream does not support BYOB readers"

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:94: const
errGetReaderBadMode = 'Invalid mode is specified';
'Invalid reader mode given: expected undefined or "byob"'

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:136: const type =
underlyingSource['type'];
Nit: use .type notation

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:168: getReader() {
In recent versions of Chrome we can do this as `getReader({ mode } = {}). I
should update the spec to use { mode } instead of options.

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:238: return
ReadableStreamDefaultControllerError(controller, r);
Nit: no need for return here

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/streams/ReadableStreamController.h (right):

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStreamController.h:53:
v8::Local<v8::Value> args[] = { stream };
Don't you need to pass the controller now, not the stream? Here and all other
parts of this file, but also all call sites need to change too, right??

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/streams/ReadableStreamOperations.h (right):

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStreamOperations.h:71: static
ScriptPromise read(ScriptState*, ScriptValue reader);
Maybe this should be named defaultReaderRead now

[tyoshino (SeeGerritForStatus), 2016-04-28 10:32:49]

On 2016/04/27 21:12:24, domenic wrote:
> The change to no longer use null controller needs more work on the C++ side, I
> am pretty sure. I noted in my line comments.
> 
> It is a bit sad that we no longer get to avoid the controller overhead, but I
> guess since so much logic is in the controller now it makes sense that we need
> to keep it.

For some cases where queuing is unnecessary, we can even skip the controller and
directly access the ReadableStream. We're guessing we can do that for the Fetch
implementation.

This initial change just keeps using the controller, but further redesign may
happen later.

[tyoshino (SeeGerritForStatus), 2016-04-28 14:51:11]

Thanks Domenic!

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:28: const
readableStreamBits = v8.createPrivateSymbol('bit field for [[disturbed]]');
On 2016/04/27 21:12:23, domenic wrote:
> It's a bit unfortunate that we need a whole new 64 bits or so just for this.
Is
> it possible to move it into the readableStreamDefaultControllerBits, with a
> comment saying that that's not how the spec works but we're doing it for
> efficiency?

Oh, yes.

Combined with [[state]] instead.

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:86: const
errEnqueueClosedStream = 'Cannot enqueue a closed readable stream';
On 2016/04/27 21:12:24, domenic wrote:
> "Cannot enqueue a chunk into a closed readable stream"

Done.

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:87: const
errEnqueueErroredStream = 'Cannot enqueue an errored readable stream';
On 2016/04/27 21:12:24, domenic wrote:
> "Cannot enqueue a chunk into an errored readable stream"

Done.

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:93: const
errGetReaderNotByteStream = 'Cannot get a ReadableStreamBYOBReader for a stream
not constructed with a byte source';
On 2016/04/27 21:12:24, domenic wrote:
> "This readable stream does not support BYOB readers"

Done.

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:94: const
errGetReaderBadMode = 'Invalid mode is specified';
On 2016/04/27 21:12:24, domenic wrote:
> 'Invalid reader mode given: expected undefined or "byob"'

Done.

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:136: const type =
underlyingSource['type'];
On 2016/04/27 21:12:23, domenic wrote:
> Nit: use .type notation

Done.

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:168: getReader() {
On 2016/04/27 21:12:23, domenic wrote:
> In recent versions of Chrome we can do this as `getReader({ mode } = {}). I
> should update the spec to use { mode } instead of options.

Done.

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:238: return
ReadableStreamDefaultControllerError(controller, r);
On 2016/04/27 21:12:24, domenic wrote:
> Nit: no need for return here

Done.

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/streams/ReadableStreamController.h (right):

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStreamController.h:53:
v8::Local<v8::Value> args[] = { stream };
On 2016/04/27 21:12:24, domenic wrote:
> Don't you need to pass the controller now, not the stream? Here and all other
> parts of this file, but also all call sites need to change too, right??

Right! Just forgot to. Done.

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/streams/ReadableStreamOperations.h (right):

https://codereview.chromium.org/1902673003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStreamOperations.h:71: static
ScriptPromise read(ScriptState*, ScriptValue reader);
On 2016/04/27 21:12:24, domenic wrote:
> Maybe this should be named defaultReaderRead now

Done.

[domenic, 2016-04-28 19:13:31]

UnderlyingSourceBase.cpp needs to be updated to do `new
ReadableStreamController(controller)` (just a variable name change), and the JS
needs to be updated to not pass `this` to the `start` method unless the
controller is externally controlled (that used to be handled by the argToStart
code).

[domenic, 2016-04-28 19:16:15]

On 2016/04/28 at 19:13:31, domenic wrote:
> UnderlyingSourceBase.cpp needs to be updated to do `new
ReadableStreamController(controller)` (just a variable name change), and the JS
in the ReadableStreamDefaultController constructor needs to be updated to not
pass `this` to the `start` method unless the controller is externally controlled
(that used to be handled by the argToStart code).

Bug should also probably be 503491.

LGTM with these changes. There will probably be more changes when we implement
byte streams, e.g. maybe there will be two C++ controller classes, but for now
it seems good to do as you've done here.

[tyoshino (SeeGerritForStatus), 2016-05-02 05:36:24]

Description was changed from

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=none
==========

to

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=503491
==========

[tyoshino (SeeGerritForStatus), 2016-05-02 05:43:28]

On 2016/04/28 19:13:31, domenic wrote:
> UnderlyingSourceBase.cpp needs to be updated to do `new
> ReadableStreamController(controller)` (just a variable name change), and the
JS

Yeah. Done

> needs to be updated to not pass `this` to the `start` method unless the
> controller is externally controlled (that used to be handled by the argToStart
> code).

Hmm, now both the externally controlled one and JS controlled one need to pass
the controller instance to the controller entity. So, there should be no
difference in start invocation logic in ReadableStream.js, I think.

[tyoshino (SeeGerritForStatus), 2016-05-02 05:44:11]

On 2016/04/28 19:16:15, domenic wrote:
> On 2016/04/28 at 19:13:31, domenic wrote:
> > UnderlyingSourceBase.cpp needs to be updated to do `new
> ReadableStreamController(controller)` (just a variable name change), and the
JS
> in the ReadableStreamDefaultController constructor needs to be updated to not
> pass `this` to the `start` method unless the controller is externally
controlled
> (that used to be handled by the argToStart code).
> 
> Bug should also probably be 503491.

Assigned.

> LGTM with these changes. There will probably be more changes when we implement
> byte streams, e.g. maybe there will be two C++ controller classes, but for now
> it seems good to do as you've done here.

Yeah. I'll do them in the next CLs.

[tyoshino (SeeGerritForStatus), 2016-05-02 06:11:21]

Description was changed from

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=503491
==========

to

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=503491,608259
==========

[domenic, 2016-05-02 13:05:02]

On 2016/05/02 at 05:43:28, tyoshino wrote:

> Hmm, now both the externally controlled one and JS controlled one need to pass
the controller instance to the controller entity. So, there should be no
difference in start invocation logic in ReadableStream.js, I think.

Oh, I see, oops. That makes sense, of course. LGTM!

[yhirano, 2016-05-02 13:17:04]

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:125:
this[readableStreamBits] = 0b0 | STATE_READABLE;
STATE_READBLE << OFFSET?

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:185: throw new
RangeError(errGetReaderBadMode);;
;;

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:234: if
((stream[readableStreamBits] & STATE_MASK) >> 1 === STATE_READABLE) {
ReadableStreamGetState(this) or s/1/STATE_BITS_OFFSET/

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:259: const state =
(stream[readableStreamBits] & STATE_MASK) >> 1;
ditto

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:281: const state =
(stream[readableStreamBits] & STATE_MASK) >> 1;
ditto

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:299: const state =
(stream[readableStreamBits] & STATE_MASK) >> 1;
ditto

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:324: if
(controller[readableStreamDefaultControllerBits] & CLOSE_REQUESTED &&
controller[readableStreamDefaultControllerQueue].length === 0) {
Can you add a pair of parenthesis around (controller[...] & CLOSE_REQUESTED)?

[tyoshino (SeeGerritForStatus), 2016-05-06 06:24:57]

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:125:
this[readableStreamBits] = 0b0 | STATE_READABLE;
On 2016/05/02 13:17:03, yhirano wrote:
> STATE_READBLE << OFFSET?

Changed to use ReadableStreamSetState()

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:185: throw new
RangeError(errGetReaderBadMode);;
On 2016/05/02 13:17:03, yhirano wrote:
> ;;

Done.

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:234: if
((stream[readableStreamBits] & STATE_MASK) >> 1 === STATE_READABLE) {
On 2016/05/02 13:17:03, yhirano wrote:
> ReadableStreamGetState(this) or s/1/STATE_BITS_OFFSET/

Replaced with ReadableStreamGetState() call.

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:259: const state =
(stream[readableStreamBits] & STATE_MASK) >> 1;
On 2016/05/02 13:17:04, yhirano wrote:
> ditto

Replaced with ReadableStreamGetState() call.

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:281: const state =
(stream[readableStreamBits] & STATE_MASK) >> 1;
On 2016/05/02 13:17:04, yhirano wrote:
> ditto

Replaced with ReadableStreamGetState() call.

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:299: const state =
(stream[readableStreamBits] & STATE_MASK) >> 1;
On 2016/05/02 13:17:04, yhirano wrote:
> ditto

Replaced with ReadableStreamGetState() call.

https://codereview.chromium.org/1902673003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:324: if
(controller[readableStreamDefaultControllerBits] & CLOSE_REQUESTED &&
controller[readableStreamDefaultControllerQueue].length === 0) {
On 2016/05/02 13:17:04, yhirano wrote:
> Can you add a pair of parenthesis around (controller[...] & CLOSE_REQUESTED)?

Done.

[yhirano, 2016-05-06 11:26:58]

lgtm

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:378: return
ReadableStreamReaderGenericCancel(this, reason);
[optional]: the spec uses ReadableStreamCancel directly.

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:518: for (let i = 0; i
< readRequests.length; ++i) {
[optional] You can use |for...of|.

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:523: const
readIntoRequests = reader[readableStreamReaderReadIntoRequests];
Non-default reader appears only here.

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:524: for (let i = 0; i
< readIntoRequests.length; ++i) {
ditto

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:543: for (let i = 0; i
< readRequests.length; ++i) {
[optional] You can use |for...of|.

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:682: return
ReadableStreamDefaultControllerCallPullIfNeeded(controller);
[optional] Is |return| needed?

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:687: return
ReadableStreamDefaultControllerError(controller, e);
ditto

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:692: function
ReadableStreamDefaultControllerShouldPull(controller) {
[optional] Its name is ReadableStreamDefaultControllerShouldUsePull in the spec.

[tyoshino (SeeGerritForStatus), 2016-05-06 12:40:48]

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:378: return
ReadableStreamReaderGenericCancel(this, reason);
On 2016/05/06 11:26:58, yhirano wrote:
> [optional]: the spec uses ReadableStreamCancel directly.

Looks the spec is broken. I'll fix.

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:518: for (let i = 0; i
< readRequests.length; ++i) {
On 2016/05/06 11:26:58, yhirano wrote:
> [optional] You can use |for...of|.

Hmm, tried but it doesn't work. Maybe v8.InternalPackedArray() is not iterable?

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:523: const
readIntoRequests = reader[readableStreamReaderReadIntoRequests];
On 2016/05/06 11:26:58, yhirano wrote:
> Non-default reader appears only here.

removed

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:524: for (let i = 0; i
< readIntoRequests.length; ++i) {
On 2016/05/06 11:26:58, yhirano wrote:
> ditto

Done.

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:543: for (let i = 0; i
< readRequests.length; ++i) {
On 2016/05/06 11:26:58, yhirano wrote:
> [optional] You can use |for...of|.

Done.

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:682: return
ReadableStreamDefaultControllerCallPullIfNeeded(controller);
On 2016/05/06 11:26:58, yhirano wrote:
> [optional] Is |return| needed?

Done.

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:687: return
ReadableStreamDefaultControllerError(controller, e);
On 2016/05/06 11:26:58, yhirano wrote:
> ditto

Done.

https://codereview.chromium.org/1902673003/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/streams/ReadableStream.js:692: function
ReadableStreamDefaultControllerShouldPull(controller) {
On 2016/05/06 11:26:58, yhirano wrote:
> [optional] Its name is ReadableStreamDefaultControllerShouldUsePull in the
spec.

Added Call

[tyoshino (SeeGerritForStatus), 2016-05-06 12:41:06]

Description was changed from

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=503491,608259
==========

to

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=503491,608259
R=domenic,yhirano
==========

[tyoshino (SeeGerritForStatus), 2016-05-06 12:42:45]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-05-06 12:42:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
domenic@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1902673003/#ps200001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-06 12:42:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902673003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902673003/200001

[commit-bot: I haz the power, 2016-05-06 12:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 12:54:29]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[tyoshino (SeeGerritForStatus), 2016-05-06 13:16:19]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-05-06 13:16:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
domenic@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1902673003/#ps220001
(title: "Fixed build")

[commit-bot: I haz the power, 2016-05-06 13:16:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902673003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902673003/220001

[commit-bot: I haz the power, 2016-05-06 15:19:28]

Description was changed from

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=503491,608259
R=domenic,yhirano
==========

to

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=503491,608259
R=domenic,yhirano
==========

[commit-bot: I haz the power, 2016-05-06 15:19:29]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-05-06 15:21:08]

Description was changed from

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=503491,608259
R=domenic,yhirano
==========

to

==========
Reflect recent spec changes to V8 Extra ReadableStream impl

Readable byte stream is not yet implemented in this CL.

BUG=503491,608259
R=domenic,yhirano

Committed: https://crrev.com/b2496216b74c6d5872871c933a046340fc1fe7cf
Cr-Commit-Position: refs/heads/master@{#392058}
==========

[commit-bot: I haz the power, 2016-05-06 15:21:09]

Patchset 12 (id:??) landed as
https://crrev.com/b2496216b74c6d5872871c933a046340fc1fe7cf
Cr-Commit-Position: refs/heads/master@{#392058}