Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp

Issue 1902673003: Reflect recent spec changes to V8 Extra ReadableStream impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed build Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp
diff --git a/third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp b/third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp
index c931da167237df0b890be1324c0cf6073007af26..91f1786f9de8f5ebfa4c739f64d055b116823428 100644
--- a/third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp
+++ b/third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp
@@ -40,7 +40,7 @@ ScriptValue ReadableStreamOperations::getReader(ScriptState* scriptState, Script
v8::TryCatch block(scriptState->isolate());
v8::Local<v8::Value> args[] = { stream.v8Value() };
- ScriptValue result(scriptState, V8ScriptRunner::callExtra(scriptState, "AcquireReadableStreamReader", args));
+ ScriptValue result(scriptState, V8ScriptRunner::callExtra(scriptState, "AcquireReadableStreamDefaultReader", args));
if (block.HasCaught())
es.rethrowV8Exception(block.Exception());
return result;
@@ -97,7 +97,7 @@ bool ReadableStreamOperations::isErrored(ScriptState* scriptState, ScriptValue s
return V8ScriptRunner::callExtraOrCrash(scriptState, "IsReadableStreamErrored", args)->ToBoolean()->Value();
}
-bool ReadableStreamOperations::isReadableStreamReader(ScriptState* scriptState, ScriptValue value)
+bool ReadableStreamOperations::isReadableStreamDefaultReader(ScriptState* scriptState, ScriptValue value)
{
ASSERT(!value.isEmpty());
@@ -105,16 +105,15 @@ bool ReadableStreamOperations::isReadableStreamReader(ScriptState* scriptState,
return false;
v8::Local<v8::Value> args[] = { value.v8Value() };
- return V8ScriptRunner::callExtraOrCrash(scriptState, "IsReadableStreamReader", args)->ToBoolean()->Value();
+ return V8ScriptRunner::callExtraOrCrash(scriptState, "IsReadableStreamDefaultReader", args)->ToBoolean()->Value();
}
-ScriptPromise ReadableStreamOperations::read(ScriptState* scriptState, ScriptValue reader)
+ScriptPromise ReadableStreamOperations::defaultReaderRead(ScriptState* scriptState, ScriptValue reader)
{
- ASSERT(isReadableStreamReader(scriptState, reader));
+ ASSERT(isReadableStreamDefaultReader(scriptState, reader));
v8::Local<v8::Value> args[] = { reader.v8Value() };
- return ScriptPromise::cast(scriptState, V8ScriptRunner::callExtraOrCrash(scriptState, "ReadFromReadableStreamReader", args));
+ return ScriptPromise::cast(scriptState, V8ScriptRunner::callExtraOrCrash(scriptState, "ReadableStreamDefaultReaderRead", args));
}
} // namespace blink
-

Powered by Google App Engine
This is Rietveld 408576698