Reflect recent spec changes to V8 Extra ReadableStream impl

third_party/WebKit/Source/core/streams/ReadableStreamController.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ReadableStreamController_h
 #define ReadableStreamController_h
 
 #include "bindings/core/v8/ScopedPersistent.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/ToV8.h"
@@ skipping 32 matching lines @@
     void close()
     {
         ScriptState* scriptState = m_scriptState.get();
         ScriptState::Scope scope(scriptState); // will assert context is valid; do not call this method when the context is invalidated
         v8::Isolate* isolate = scriptState->isolate();
 
         v8::Local<v8::Value> stream = m_stream.newLocal(isolate);
         if (stream.IsEmpty())
             return;
 
         v8::Local<v8::Value> args[] = { stream };

[domenic, 2016/04/27 21:12:24]

Don't you need to pass the controller now, not the stream? Here and all other
parts of this file, but also all call sites need to change too, right??

[tyoshino (SeeGerritForStatus), 2016/04/28 14:51:11]

Right! Just forgot to. Done.

-        V8ScriptRunner::callExtraOrCrash(scriptState, "CloseReadableStream", args);
+        V8ScriptRunner::callExtraOrCrash(scriptState, "ReadableStreamDefaultControllerClose", args);
 
         m_stream.clear();
     }
 
     double desiredSize() const
     {
         ScriptState* scriptState = m_scriptState.get();
         ScriptState::Scope scope(scriptState); // will assert context is valid; do not call this method when the context is invalidated
         v8::Isolate* isolate = scriptState->isolate();
 
         v8::Local<v8::Value> stream = m_stream.newLocal(isolate);
         if (stream.IsEmpty())
             return 0;
 
         v8::Local<v8::Value> args[] = { stream };
-        v8::Local<v8::Value> result = V8ScriptRunner::callExtraOrCrash(scriptState, "GetReadableStreamDesiredSize", args);
+        v8::Local<v8::Value> result = V8ScriptRunner::callExtraOrCrash(scriptState, "ReadableStreamDefaultControllerGetDesiredSize", args);
 
         return result.As<v8::Number>()->Value();
     }
 
     template <typename ChunkType>
     void enqueue(ChunkType chunk) const
     {
         ScriptState* scriptState = m_scriptState.get();
         ScriptState::Scope scope(scriptState); // will assert context is valid; do not call this method when the context is invalidated
         v8::Isolate* isolate = scriptState->isolate();
 
         v8::Local<v8::Value> stream = m_stream.newLocal(isolate);
         if (stream.IsEmpty())
             return;
 
         v8::Local<v8::Value> jsChunk = toV8(chunk, scriptState);
         v8::Local<v8::Value> args[] = { stream, jsChunk };
-        V8ScriptRunner::callExtraOrCrash(scriptState, "EnqueueInReadableStream", args);
+        V8ScriptRunner::callExtraOrCrash(scriptState, "ReadableStreamDefaultControllerEnqueue", args);
     }
 
     template <typename ErrorType>
     void error(ErrorType error)
     {
         ScriptState* scriptState = m_scriptState.get();
         ScriptState::Scope scope(scriptState); // will assert context is valid; do not call this method when the context is invalidated
         v8::Isolate* isolate = scriptState->isolate();
 
         v8::Local<v8::Value> stream = m_stream.newLocal(isolate);
         if (stream.IsEmpty())
             return;
 
         v8::Local<v8::Value> jsError = toV8(error, scriptState);
         v8::Local<v8::Value> args[] = { stream, jsError };
-        V8ScriptRunner::callExtraOrCrash(scriptState, "ErrorReadableStream", args);
+        V8ScriptRunner::callExtraOrCrash(scriptState, "ReadableStreamDefaultControllerError", args);
 
         m_stream.clear();
     }
 
 private:
     static void streamWeakCallback(const v8::WeakCallbackInfo<ScopedPersistent<v8::Value>>& weakInfo)
     {
         weakInfo.GetParameter()->clear();
     }
 
     RefPtr<ScriptState> m_scriptState;
     ScopedPersistent<v8::Value> m_stream;
 };
 
 } // namespace blink
 
 #endif // ReadableStreamController_h