third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp - Issue 1902673003: Reflect recent spec changes to V8 Extra ReadableStream impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp

Issue 1902673003: Reflect recent spec changes to V8 Extra ReadableStream impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed build Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp ('k') | third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp

diff --git a/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp b/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp

index d1a2c4c925c14d72b3fc8af5ab8ecf54f6d512c7..c293f53bdff084e636d8593db00bf0dad701ba3f 100644

--- a/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp

+++ b/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp

@@ -12,15 +12,12 @@

namespace blink {

-ScriptPromise UnderlyingSourceBase::startWrapper(ScriptState* scriptState, ScriptValue stream)

+ScriptPromise UnderlyingSourceBase::startWrapper(ScriptState* scriptState, ScriptValue jsController)

{

// Cannot call start twice (e.g., cannot use the same UnderlyingSourceBase to construct multiple streams)

ASSERT(!m_controller);

- // In ReadableStream.js, we special-case externally-controlled streams by having them pass themselves to start

- // as the first argument. This allows us to create a ReadableStreamController.

- m_controller = new ReadableStreamController(stream);

+ m_controller = new ReadableStreamController(jsController);

return start(scriptState);

}