Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1898683002: CC Animation: Erase LayerAnimationEventObserver. (Closed)

Created:
4 years, 8 months ago by loyso (OOO)
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@eventobserver
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Erase LayerAnimationEventObserver. Use AnimatiodDelegate in ui::LayerAnimator instead. BUG=595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c Cr-Commit-Position: refs/heads/master@{#388082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -195 lines) Patch
M cc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M cc/animation/element_animations.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/animation/element_animations.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/animation/layer_animation_controller.h View 3 chunks +1 line, -4 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D cc/animation/layer_animation_event_observer.h View 1 chunk +0 lines, -25 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/layer_animation_sequence.h View 2 chunks +3 lines, -5 lines 0 comments Download
M ui/compositor/layer_animation_sequence.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M ui/compositor/layer_animation_sequence_unittest.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M ui/compositor/layer_animator.h View 4 chunks +21 lines, -5 lines 0 comments Download
M ui/compositor/layer_animator.cc View 5 chunks +16 lines, -13 lines 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 11 chunks +36 lines, -49 lines 0 comments Download
M ui/compositor/test/layer_animator_test_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1893253002 Patch 1

Messages

Total messages: 12 (6 generated)
loyso (OOO)
4 years, 8 months ago (2016-04-18 07:34:59 UTC) #4
ajuma
lgtm
4 years, 8 months ago (2016-04-18 13:27:56 UTC) #5
Ian Vollick
On 2016/04/18 13:27:56, ajuma wrote: > lgtm lgtm.
4 years, 8 months ago (2016-04-18 23:40:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898683002/1
4 years, 8 months ago (2016-04-18 23:41:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 23:46:52 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 23:48:01 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c
Cr-Commit-Position: refs/heads/master@{#388082}

Powered by Google App Engine
This is Rietveld 408576698