Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: ui/compositor/layer_animator.h

Issue 1898683002: CC Animation: Erase LayerAnimationEventObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@eventobserver
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/compositor/layer_animation_sequence_unittest.cc ('k') | ui/compositor/layer_animator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/layer_animator.h
diff --git a/ui/compositor/layer_animator.h b/ui/compositor/layer_animator.h
index c9dedd027d291a90bacc0083319bedc9c1cccf3e..9bd9f058e3bac88dadd52617def36f063d3805f3 100644
--- a/ui/compositor/layer_animator.h
+++ b/ui/compositor/layer_animator.h
@@ -15,7 +15,8 @@
#include "base/memory/ref_counted.h"
#include "base/observer_list.h"
#include "base/time/time.h"
-#include "cc/animation/layer_animation_event_observer.h"
+#include "cc/animation/animation_delegate.h"
+#include "cc/animation/target_property.h"
#include "ui/compositor/compositor_export.h"
#include "ui/compositor/layer_animation_element.h"
#include "ui/compositor/layer_threaded_animation_delegate.h"
@@ -56,7 +57,7 @@ class ScopedLayerAnimationSettings;
class COMPOSITOR_EXPORT LayerAnimator
: public base::RefCounted<LayerAnimator>,
public LayerThreadedAnimationDelegate,
- NON_EXPORTED_BASE(public cc::LayerAnimationEventObserver) {
+ NON_EXPORTED_BASE(public cc::AnimationDelegate) {
public:
enum PreemptionStrategy {
IMMEDIATELY_SET_NEW_TARGET,
@@ -196,7 +197,9 @@ class COMPOSITOR_EXPORT LayerAnimator
void RemoveObserver(LayerAnimationObserver* observer);
// Called when a threaded animation is actually started.
- void OnThreadedAnimationStarted(const cc::AnimationEvent& event);
+ void OnThreadedAnimationStarted(base::TimeTicks monotonic_time,
+ cc::TargetProperty::Type target_property,
+ int group_id);
// This determines how implicit animations will be tweened. This has no
// effect on animations that are explicitly started or scheduled. The default
@@ -339,8 +342,21 @@ class COMPOSITOR_EXPORT LayerAnimator
LayerAnimatorCollection* GetLayerAnimatorCollection();
- // LayerAnimationEventObserver
- void OnAnimationStarted(const cc::AnimationEvent& event) override;
+ // cc::AnimationDelegate implementation.
+ void NotifyAnimationStarted(base::TimeTicks monotonic_time,
+ cc::TargetProperty::Type target_property,
+ int group_id) override;
+ void NotifyAnimationFinished(base::TimeTicks monotonic_time,
+ cc::TargetProperty::Type target_property,
+ int group_id) override {}
+ void NotifyAnimationAborted(base::TimeTicks monotonic_time,
+ cc::TargetProperty::Type target_property,
+ int group_id) override {}
+ void NotifyAnimationTakeover(
+ base::TimeTicks monotonic_time,
+ cc::TargetProperty::Type target_property,
+ double animation_start_time,
+ std::unique_ptr<cc::AnimationCurve> curve) override {}
// Implementation of LayerThreadedAnimationDelegate.
void AddThreadedAnimation(std::unique_ptr<cc::Animation> animation) override;
« no previous file with comments | « ui/compositor/layer_animation_sequence_unittest.cc ('k') | ui/compositor/layer_animator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698