Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1893253002: CC Animation: Make LayerAnimationController to have just one event observer. (Closed)

Created:
4 years, 8 months ago by loyso (OOO)
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Make LayerAnimationController to have just one event observer. Next step: unify LayerAnimationEventObserver with AnimationDelegate in the dependent CL. BUG=595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/deaa7fda6ae480160e3b0d5f86ca984a4c3eff1b Cr-Commit-Position: refs/heads/master@{#388072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -36 lines) Patch
M cc/animation/element_animations.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/animation/element_animations.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M cc/animation/layer_animation_controller.h View 4 chunks +3 lines, -6 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 4 chunks +7 lines, -12 lines 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/compositor/layer_animator.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
loyso (OOO)
4 years, 8 months ago (2016-04-18 06:05:31 UTC) #4
ajuma
lgtm
4 years, 8 months ago (2016-04-18 13:23:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893253002/1
4 years, 8 months ago (2016-04-18 23:12:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 23:19:17 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 23:21:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/deaa7fda6ae480160e3b0d5f86ca984a4c3eff1b
Cr-Commit-Position: refs/heads/master@{#388072}

Powered by Google App Engine
This is Rietveld 408576698