Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3579)

Unified Diff: ash/system/date/date_view.cc

Issue 1898633004: Views: Add new SetFocusBehavior method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/date/date_view.cc
diff --git a/ash/system/date/date_view.cc b/ash/system/date/date_view.cc
index 7a96d9c0c0469fe28d82326ab90f319fbdcecc14..bdde34aa52d21a371a1dd299c1f6dd08c3b8e1e0 100644
--- a/ash/system/date/date_view.cc
+++ b/ash/system/date/date_view.cc
@@ -138,7 +138,7 @@ DateView::DateView()
date_label_->SetEnabledColor(kHeaderTextColorNormal);
UpdateTextInternal(base::Time::Now());
AddChildView(date_label_);
- SetFocusable(false);
+ SetFocusBehavior(FocusBehavior::NEVER);
tapted 2016/04/20 04:16:28 (wait for sky to comment on this, but I wonder if
sky 2016/04/20 19:26:02 I don't feel strongly here. I'm ok either way.
karandeepb 2016/04/21 03:16:33 I don't think we should do this since ActionableVi
}
DateView::~DateView() {
@@ -154,7 +154,8 @@ void DateView::SetAction(TrayDate::DateAction action) {
SchedulePaint();
}
action_ = action;
- SetFocusable(action_ != TrayDate::NONE);
+ SetFocusBehavior(action_ != TrayDate::NONE ? FocusBehavior::ALWAYS
+ : FocusBehavior::NEVER);
}
void DateView::UpdateTimeFormat() {
@@ -226,7 +227,7 @@ TimeView::TimeView(TrayDate::ClockLayout clock_layout)
SetupLabels();
UpdateTextInternal(base::Time::Now());
UpdateClockLayout(clock_layout);
- SetFocusable(false);
+ SetFocusBehavior(FocusBehavior::NEVER);
}
TimeView::~TimeView() {

Powered by Google App Engine
This is Rietveld 408576698