Views: Add new SetFocusBehavior method.

chrome/browser/ui/views/find_bar_view.cc

Index: chrome/browser/ui/views/find_bar_view.cc
diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc
index da010487e4781e0cf0174b18e68faf1b7d00f418..a27fbc90cdf22d45eae7bcb524cbc8b26353bb09 100644
--- a/chrome/browser/ui/views/find_bar_view.cc
+++ b/chrome/browser/ui/views/find_bar_view.cc
@@ -154,7 +154,7 @@ FindBarView::FindBarView(FindBarHost* host)
   }
 
   find_previous_button_->set_id(VIEW_ID_FIND_IN_PAGE_PREVIOUS_BUTTON);
-  find_previous_button_->SetFocusable(true);
+  find_previous_button_->SetFocusBehavior(FocusBehavior::ALWAYS);

[Evan Stade, 2016/04/20 21:17:04]

why do you need the FocusBehavior:: qualifier? Is that because it's enum class?
Why not just use a plain enum in that case?

[karandeepb, 2016/04/21 03:16:33]

Yeah it's an enum class. I am using it just because it offers more type safety
and the same was suggested to me in an earlier review. Also even with a plain
enum, since ALWAYS and NEVER are quite common words, I'll have to change them to
something like FOCUS_ALWAYS|NEVER.

   find_previous_button_->set_request_focus_on_press(false);
   find_previous_button_->SetTooltipText(
       l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_PREVIOUS_TOOLTIP));
@@ -163,7 +163,7 @@ FindBarView::FindBarView(FindBarHost* host)
   AddChildView(find_previous_button_);
 
   find_next_button_->set_id(VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON);
-  find_next_button_->SetFocusable(true);
+  find_next_button_->SetFocusBehavior(FocusBehavior::ALWAYS);
   find_next_button_->set_request_focus_on_press(false);
   find_next_button_->SetTooltipText(
       l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_NEXT_TOOLTIP));
@@ -172,7 +172,7 @@ FindBarView::FindBarView(FindBarHost* host)
   AddChildView(find_next_button_);
 
   close_button_->set_id(VIEW_ID_FIND_IN_PAGE_CLOSE_BUTTON);
-  close_button_->SetFocusable(true);
+  close_button_->SetFocusBehavior(FocusBehavior::ALWAYS);
   close_button_->set_request_focus_on_press(false);
   close_button_->SetTooltipText(
       l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_CLOSE_TOOLTIP));