Views: Add new SetFocusBehavior method.

ash/system/date/date_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/date/date_view.h"
 
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/tray_constants.h"
 #include "ash/system/tray/tray_utils.h"
@@ skipping 120 matching lines @@
     : hour_type_(ash::Shell::GetInstance()->system_tray_delegate()->
                  GetHourClockType()),
       action_(TrayDate::NONE) {
   SetLayoutManager(
       new views::BoxLayout(
           views::BoxLayout::kVertical, 0, 0, 0));
   date_label_ = CreateLabel();
   date_label_->SetEnabledColor(kHeaderTextColorNormal);
   UpdateTextInternal(base::Time::Now());
   AddChildView(date_label_);
-  SetFocusable(false);
+  SetFocusBehavior(FocusBehavior::NEVER);

[tapted, 2016/04/20 04:16:28]

(wait for sky to comment on this, but I wonder if the ash::ActionableView
constructor should be overloaded to take a `focus_behaviour_` argument, so
subclasses don't have to immediately `undo` stuff that's done there)

[sky, 2016/04/20 19:26:02]

I don't feel strongly here. I'm ok either way.

[karandeepb, 2016/04/21 03:16:33]

I don't think we should do this since ActionableView has many subclasses and
there are just 3 instances (DateView, TimeView and VolumeView) of this "undo"
behavior. Have moved the calls for DateView and TimeView to their base class
BaseDateTimeView.

 }
 
 DateView::~DateView() {
 }
 
 void DateView::SetAction(TrayDate::DateAction action) {
   if (action == action_)
     return;
   if (IsMouseHovered()) {
     date_label_->SetEnabledColor(
         action == TrayDate::NONE ? kHeaderTextColorNormal :
                                    kHeaderTextColorHover);
     SchedulePaint();
   }
   action_ = action;
-  SetFocusable(action_ != TrayDate::NONE);
+  SetFocusBehavior(action_ != TrayDate::NONE ? FocusBehavior::ALWAYS
+                                             : FocusBehavior::NEVER);
 }
 
 void DateView::UpdateTimeFormat() {
   hour_type_ =
       ash::Shell::GetInstance()->system_tray_delegate()->GetHourClockType();
   UpdateText();
 }
 
 base::HourClockType DateView::GetHourTypeForTesting() const {
   return hour_type_;
@@ skipping 51 matching lines @@
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 TimeView::TimeView(TrayDate::ClockLayout clock_layout)
     : hour_type_(ash::Shell::GetInstance()->system_tray_delegate()->
                  GetHourClockType()) {
   SetupLabels();
   UpdateTextInternal(base::Time::Now());
   UpdateClockLayout(clock_layout);
-  SetFocusable(false);
+  SetFocusBehavior(FocusBehavior::NEVER);
 }
 
 TimeView::~TimeView() {
 }
 
 void TimeView::UpdateTimeFormat() {
   hour_type_ =
       ash::Shell::GetInstance()->system_tray_delegate()->GetHourClockType();
   UpdateText();
 }
@@ skipping 93 matching lines @@
 }
 
 void TimeView::SetupLabel(views::Label* label) {
   label->set_owned_by_client();
   SetupLabelForTray(label);
   label->SetElideBehavior(gfx::NO_ELIDE);
 }
 
 }  // namespace tray
 }  // namespace ash