Views: Add new SetFocusBehavior method.

ash/sticky_keys/sticky_keys_overlay.cc

Index: ash/sticky_keys/sticky_keys_overlay.cc
diff --git a/ash/sticky_keys/sticky_keys_overlay.cc b/ash/sticky_keys/sticky_keys_overlay.cc
index 6c376cfe9e76a0a8963f95b99c80f9abd67c1b89..641488c45a53e0e869b236f361ff3f0b93a48fb2 100644
--- a/ash/sticky_keys/sticky_keys_overlay.cc
+++ b/ash/sticky_keys/sticky_keys_overlay.cc
@@ -67,7 +67,7 @@ StickyKeyOverlayLabel::StickyKeyOverlayLabel(const std::string& key_name)
   SetHorizontalAlignment(gfx::ALIGN_LEFT);
   SetFontList(rb->GetFontList(kKeyLabelFontStyle));
   SetAutoColorReadabilityEnabled(false);
-  SetFocusable(false);
+  SetFocusBehavior(FocusBehavior::NEVER);

[Evan Stade, 2016/04/20 21:17:03]

isn't NEVER the default? Why do you have to call this at all (here or elsewhere)

[karandeepb, 2016/04/21 03:16:33]

Yeah NEVER is the default. This was just refactoring the original code. The call
here is actually redundant. I think there are two reasons as to why we may use
FocusBehavior::NEVER-

1) Sometimes, as in this case, it is just to be more explicit. 
2) Also, it can be used to override the focus setting of the base class. Eg See
the SetFocusable call in ash/system/date/date_view.cc.

[Evan Stade, 2016/04/25 21:30:52]

I think we should remove it because I don't see it as more explicit, I see it as
more confusing (the old code had this problem too).

[Evan Stade, 2016/04/25 21:32:33]

oh, and maybe we can get rid of NEVER, as far as the public api is concerned. I
could imagine a valid use case for it but I also doubt that any valid uses
actually exist.

   SetEnabledColor(SkColorSetARGB(0x80, 0xFF, 0xFF, 0xFF));
   SetDisabledColor(SkColorSetARGB(0x80, 0xFF, 0xFF, 0xFF));
   SetSubpixelRenderingEnabled(false);